Fix SSL config for JDK PKCS setup#4999
Merged
cwperks merged 1 commit intoopensearch-project:mainfrom Jan 16, 2025
Merged
Conversation
Fix issue opensearch-project#4961 by defaulting the keystore_keypassword setting to the same value as the keystore_password Signed-off-by: Andrey Pleskach <ples@aiven.io>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4999 +/- ##
==========================================
- Coverage 71.50% 71.41% -0.10%
==========================================
Files 334 334
Lines 22556 22557 +1
Branches 3589 3590 +1
==========================================
- Hits 16129 16109 -20
- Misses 4635 4655 +20
- Partials 1792 1793 +1
|
cwperks
approved these changes
Dec 30, 2024
derek-ho
reviewed
Jan 16, 2025
derek-ho
approved these changes
Jan 16, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 16, 2025
Signed-off-by: Andrey Pleskach <ples@aiven.io> (cherry picked from commit 48be2af) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Set the
keystore_passwordby default same as thekeystore_keypasswordsettingIssues Resolved
#4961
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.