Skip to content

Fix codecov test coverage information for directory integration-tests #4802

Merged
willyborankin merged 1 commit intoopensearch-project:mainfrom
nibix:test-coverage-fix
Oct 9, 2024
Merged

Fix codecov test coverage information for directory integration-tests #4802
willyborankin merged 1 commit intoopensearch-project:mainfrom
nibix:test-coverage-fix

Conversation

@nibix
Copy link
Copy Markdown
Collaborator

@nibix nibix commented Oct 9, 2024

Description

Fixes #4801.

Switches the upload of integration-tests artifacts from upload-tartifact to actions/upload-artifact@v4. This will also properly include the integration-tests coverage data.

  • Category: CI fix
  • Why these changes are required? - test coverage data reported to codecov was incomplete
  • What is the old behavior before changes and new behavior after changes? - none

Issues Resolved

Resolves #4801

Testing

Test coverage gains visible in codecov: https://app.codecov.io/github/opensearch-project/security/commit/0976a9609e8e0efa8c2361372f73f592fdbb81a3/indirect-changes

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Nils Bandener <nils.bandener@eliatra.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.72%. Comparing base (5436146) to head (0976a96).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4802      +/-   ##
==========================================
+ Coverage   67.96%   70.72%   +2.76%     
==========================================
  Files         310      310              
  Lines       20938    20938              
  Branches     3326     3326              
==========================================
+ Hits        14230    14809     +579     
+ Misses       4952     4380     -572     
+ Partials     1756     1749       -7     

see 70 files with indirect coverage changes

@nibix nibix marked this pull request as ready for review October 9, 2024 11:23
@nibix nibix changed the title Switch artifact upload because of issues with upload-tartifact Fix codecov test coverage information for directory integration-tests Oct 9, 2024
@cwperks
Copy link
Copy Markdown
Member

cwperks commented Oct 9, 2024

codecov/project/plugin — 70.62% (+2.80%) compared to 5436146

Nice!

@willyborankin willyborankin merged commit f7b89f1 into opensearch-project:main Oct 9, 2024
@opensearch-trigger-bot
Copy link
Copy Markdown
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/security/backport-2.x
# Create a new branch
git switch --create backport/backport-4802-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f7b89f1c358a1acf1abc833d7d0cd08bc2415505
# Push it to GitHub
git push --set-upstream origin backport/backport-4802-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-4802-to-2.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] Test coverage information is not completely carried over to codecov

3 participants