Fix codecov test coverage information for directory integration-tests #4802
Merged
willyborankin merged 1 commit intoopensearch-project:mainfrom Oct 9, 2024
Merged
Fix codecov test coverage information for directory integration-tests #4802willyborankin merged 1 commit intoopensearch-project:mainfrom
integration-tests #4802willyborankin merged 1 commit intoopensearch-project:mainfrom
Conversation
Signed-off-by: Nils Bandener <nils.bandener@eliatra.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4802 +/- ##
==========================================
+ Coverage 67.96% 70.72% +2.76%
==========================================
Files 310 310
Lines 20938 20938
Branches 3326 3326
==========================================
+ Hits 14230 14809 +579
+ Misses 4952 4380 -572
+ Partials 1756 1749 -7 |
integration-tests
willyborankin
approved these changes
Oct 9, 2024
Member
Nice! |
cwperks
approved these changes
Oct 9, 2024
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/security/backport-2.x
# Create a new branch
git switch --create backport/backport-4802-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f7b89f1c358a1acf1abc833d7d0cd08bc2415505
# Push it to GitHub
git push --set-upstream origin backport/backport-4802-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security/backport-2.xThen, create a pull request where the |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4801.
Switches the upload of integration-tests artifacts from
upload-tartifacttoactions/upload-artifact@v4. This will also properly include the integration-tests coverage data.Issues Resolved
Resolves #4801
Testing
Test coverage gains visible in codecov: https://app.codecov.io/github/opensearch-project/security/commit/0976a9609e8e0efa8c2361372f73f592fdbb81a3/indirect-changes
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.