[Backport 2.x] [Cleanup] Remove duplication in Netty4HttpRequestHeaderVerifier#3564
Merged
[Backport 2.x] [Cleanup] Remove duplication in Netty4HttpRequestHeaderVerifier#3564
Conversation
Removes some duplication in the Netty4HttpRequestHeaderVerifier around the `/_plugins/_security/api/authtoken` endpoint and also abstracts the logic for where authentication is skipped into helper methods. Signed-off-by: Craig Perkins <craig5008@gmail.com> Signed-off-by: Craig Perkins <cwperx@amazon.com> (cherry picked from commit 900d9d5) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
DarshitChanpura,
RyanL1997,
cliu123,
cwperks,
davidlago,
peternied,
reta,
stephen-crawford and
willyborankin
as code owners
cwperks
approved these changes
Oct 18, 2023
Codecov Report
@@ Coverage Diff @@
## 2.x #3564 +/- ##
============================================
- Coverage 64.74% 64.72% -0.02%
+ Complexity 3526 3525 -1
============================================
Files 274 274
Lines 20037 20035 -2
Branches 3338 3336 -2
============================================
- Hits 12972 12967 -5
- Misses 5399 5404 +5
+ Partials 1666 1664 -2
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport 900d9d5 from #3506.