-
Notifications
You must be signed in to change notification settings - Fork 349
Rename tests #3224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename tests #3224
Conversation
Renamed: - PasswordValidatorTest -> PasswordValidatorTests - RequestContentValidatorTest -> RequestContentValidatorTests Signed-off-by: Andrey Pleskach <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #3224 +/- ##
============================================
+ Coverage 62.43% 62.45% +0.02%
Complexity 3352 3352
============================================
Files 254 254
Lines 19748 19748
Branches 3334 3334
============================================
+ Hits 12330 12334 +4
+ Misses 5789 5785 -4
Partials 1629 1629 |
peternied
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do you know this didn't work before and it works now? Is there a specific test asset / resport you are inspecting?
I see a mix files that end with Test.java and Tests.java, based on this pull request they are either both acceptable or we need to change many files.
% find src/test/. | grep Tests.java$ | wc -l
64
% find src/test/. | grep Test.java$ | wc -l
115
Well I just recall that all tests in OS plugins should have name like |
|
|
Description
Renamed:
PasswordValidatorTest->PasswordValidatorTestsRequestContentValidatorTest->RequestContentValidatorTestsIt looks like naming affects test coverage calculations
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.