Skip to content

Conversation

@willyborankin
Copy link
Collaborator

Description

Renamed:

  • PasswordValidatorTest -> PasswordValidatorTests
  • RequestContentValidatorTest -> RequestContentValidatorTests
    It looks like naming affects test coverage calculations

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Renamed:
 - PasswordValidatorTest -> PasswordValidatorTests
 - RequestContentValidatorTest -> RequestContentValidatorTests
Signed-off-by: Andrey Pleskach <[email protected]>
@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Merging #3224 (fa83fb4) into main (f377702) will increase coverage by 0.02%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #3224      +/-   ##
============================================
+ Coverage     62.43%   62.45%   +0.02%     
  Complexity     3352     3352              
============================================
  Files           254      254              
  Lines         19748    19748              
  Branches       3334     3334              
============================================
+ Hits          12330    12334       +4     
+ Misses         5789     5785       -4     
  Partials       1629     1629              

see 2 files with indirect coverage changes

Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you know this didn't work before and it works now? Is there a specific test asset / resport you are inspecting?

I see a mix files that end with Test.java and Tests.java, based on this pull request they are either both acceptable or we need to change many files.

% find src/test/. | grep Tests.java$ | wc -l
64
% find src/test/. | grep Test.java$ | wc -l
115

@willyborankin
Copy link
Collaborator Author

willyborankin commented Aug 22, 2023

How do you know this didn't work before and it works now? Is there a specific test asset / resport you are inspecting?

I see a mix files that end with Test.java and Tests.java, based on this pull request they are either both acceptable or we need to change many files.

% find src/test/. | grep Tests.java$ | wc -l
64
% find src/test/. | grep Test.java$ | wc -l
115

Well I just recall that all tests in OS plugins should have name like *Tests so maybe it reduce maybe not. If you think that it doesn't I will close PR.

@peternied
Copy link
Member

codecov/patch Successful in 1s — Coverage not affected when comparing f377702...fa83fb4 - Seems like we don't need to renaming anything, I am closing this PR.

@peternied peternied closed this Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants