Add code coverage exclusions on false positives#3196
Merged
peternied merged 4 commits intoopensearch-project:mainfrom Aug 21, 2023
Merged
Add code coverage exclusions on false positives#3196peternied merged 4 commits intoopensearch-project:mainfrom
peternied merged 4 commits intoopensearch-project:mainfrom
Conversation
Signed-off-by: Peter Nied <petern@amazon.com>
peternied
requested review from
DarshitChanpura,
RyanL1997,
cliu123,
cwperks,
davidlago,
reta,
stephen-crawford and
willyborankin
as code owners
peternied
changed the title
Codecov Report
@@ Coverage Diff @@
## main #3196 +/- ##
============================================
- Coverage 62.46% 62.42% -0.05%
+ Complexity 3354 3352 -2
============================================
Files 254 254
Lines 19749 19748 -1
Branches 3334 3334
============================================
- Hits 12337 12327 -10
- Misses 5784 5788 +4
- Partials 1628 1633 +5 |
Signed-off-by: Peter Nied <petern@amazon.com>
peternied
commented
Aug 16, 2023
cwperks
reviewed
Aug 17, 2023
Signed-off-by: Peter Nied <petern@amazon.com>
Signed-off-by: Peter Nied <petern@amazon.com>
DarshitChanpura
approved these changes
Aug 21, 2023
3 tasks
cwperks
approved these changes
Aug 21, 2023
Member
cwperks
left a comment
cwperks
left a comment
There was a problem hiding this comment.
@peternied I'm approving this PR, but also had a question. Could this be achieved using java annotations?
Member
Author
Codecov doesn't support any java annotations that I'm aware of. The only really annotations that I've seen used in the code coverage space are about automatically excluding code that was generated, such as by adding your own @.generated annotation example. |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 22, 2023
Adding code coverage exclusions on files that are creating code coverage measurement issues. Signed-off-by: Peter Nied <petern@amazon.com> (cherry picked from commit 07406d6) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding code coverage exclusions on files that are creating code coverage measurement issues.
Issues Resolved
Testing
Will be checking the codecov output on this PR and expect it to come back clean. Might need to iterate a couple times to make sure the max threshold % amount is correct.
Check List
New functionality includes testingNew functionality has been documentedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.