[Backport 2.x] Fix the import org.opensearch.core.common.Strings; and import org.opensearch.core.common.logging.LoggerMessageFormat;

[cwperks]

Backport #2781 to 2.x

This PR also includes a fix for: #2950

[cwperks]

There's an issue with the common-utils version:

org.opensearch.security.sanity.tests.SingleClusterSanityIT > testSecurityPluginInstallation FAILED
    java.lang.NoSuchMethodError: 'boolean org.opensearch.common.Strings.isNullOrEmpty(java.lang.String)'
        at org.opensearch.commons.rest.SecureRestClientBuilder.<init>(SecureRestClientBuilder.java:111)

I'm going to check if common-utils has fixed the issue and updating the dependency in this repo to 2.9.0.0-SNAPSHOT

[cwperks]

common-utils has fixed the issue on 2.x: opensearch-project/common-utils#474

[cwperks]

I set this to SNAPSHOT, but this should be changed to a release version ASAP.

[cwperks]

@opensearch-project/engineering-effectiveness Can a new SNAPSHOT for common-utils 2.9.0.0 be published? https://aws.oss.sonatype.org/content/repositories/snapshots/org/opensearch/common-utils/2.9.0.0-SNAPSHOT/

Security needs a version of the jar with this change included.

[gaiksaya]

@opensearch-project/engineering-effectiveness Can a new SNAPSHOT for common-utils 2.9.0.0 be published? https://aws.oss.sonatype.org/content/repositories/snapshots/org/opensearch/common-utils/2.9.0.0-SNAPSHOT/

Security needs a version of the jar with this change included.

Triggered here: https://github.com/opensearch-project/common-utils/actions/runs/5486967416

The process is now moved to GHA and owned by respective team. Looks like a PR is in review to fix the triggers: opensearch-project/common-utils#475

[cwperks]

Thank you @gaiksaya !

[codecov]

Codecov Report

Merging #2953 (c40466d) into 2.x (010e444) will decrease coverage by 0.09%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                2.x    #2953      +/-   ##
============================================
- Coverage     62.13%   62.05%   -0.09%     
+ Complexity     3374     3367       -7     
============================================
  Files           264      264              
  Lines         19440    19440              
  Branches       3314     3314              
============================================
- Hits          12080    12063      -17     
- Misses         5764     5776      +12     
- Partials       1596     1601       +5     

Impacted Files	Coverage Δ
...ic/auth/http/jwt/AbstractHTTPJwtAuthenticator.java	58.42% <ø> (ø)
...ic/auth/ldap/backend/LDAPAuthorizationBackend.java	57.38% <ø> (ø)
...zon/dlic/auth/ldap2/LDAPAuthorizationBackend2.java	31.22% <ø> (ø)
...opensearch/security/auditlog/sink/WebhookSink.java	76.47% <ø> (ø)
...ensearch/security/compliance/ComplianceConfig.java	84.21% <ø> (ø)
...earch/security/dlic/rest/api/AccountApiAction.java	84.05% <ø> (ø)
...rity/dlic/rest/api/PatchableResourceApiAction.java	86.25% <ø> (ø)
...ity/dlic/rest/validation/CredentialsValidator.java	70.00% <ø> (ø)
...curity/dlic/rest/validation/PasswordValidator.java	82.53% <ø> (ø)
...org/opensearch/security/filter/SecurityFilter.java	66.34% <ø> (ø)
... and 8 more

... and 7 files with indirect coverage changes