Add password message to /dashboardsinfo endpoint#2949
Merged
cwperks merged 2 commits intoopensearch-project:mainfrom Jul 7, 2023
Merged
Add password message to /dashboardsinfo endpoint#2949cwperks merged 2 commits intoopensearch-project:mainfrom
cwperks merged 2 commits intoopensearch-project:mainfrom
Conversation
Signed-off-by: Craig Perkins <cwperx@amazon.com>
cwperks
requested review from
DarshitChanpura,
RyanL1997,
cliu123,
davidlago,
peternied,
reta,
stephen-crawford and
willyborankin
as code owners
3 tasks
Codecov Report
@@ Coverage Diff @@
## main #2949 +/- ##
=============================================
- Coverage 62.31% 30.19% -32.13%
+ Complexity 3337 1537 -1800
=============================================
Files 266 266
Lines 19650 19652 +2
Branches 3329 3329
=============================================
- Hits 12244 5933 -6311
- Misses 5779 12753 +6974
+ Partials 1627 966 -661
|
DarshitChanpura
previously approved these changes
Jul 6, 2023
Member
DarshitChanpura
left a comment
DarshitChanpura
left a comment
There was a problem hiding this comment.
Looks good. I nit suggestion.
| .build(); | ||
|
|
||
| @Test | ||
| public void testNegativeLookaheadPattern() throws Exception { |
Member
There was a problem hiding this comment.
nit: testValidationMessageDisplayed. Same for the test in the file above.
Member
Author
There was a problem hiding this comment.
Woops, forgot to update the name. This is updated now. The push dismissed your review so you will need to re-approve the PR.
willyborankin
previously approved these changes
Jul 6, 2023
Signed-off-by: Craig Perkins <cwperx@amazon.com>
cwperks
dismissed stale reviews from willyborankin and DarshitChanpura
via
0bbd73c
willyborankin
approved these changes
Jul 6, 2023
RyanL1997
approved these changes
Jul 6, 2023
Collaborator
|
LGTM and approved. Thanks @cwperks for taking this on! |
willyborankin
approved these changes
Jul 7, 2023
3 tasks
stephen-crawford
approved these changes
Jul 7, 2023
Contributor
stephen-crawford
left a comment
stephen-crawford
left a comment
There was a problem hiding this comment.
Looks good! Thanks Craig.
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 7, 2023
* Add password message to /dashboardsinfo endpoint Signed-off-by: Craig Perkins <cwperx@amazon.com> * Update test names Signed-off-by: Craig Perkins <cwperx@amazon.com> --------- Signed-off-by: Craig Perkins <cwperx@amazon.com> (cherry picked from commit 47c4feb)
cwperks
added a commit
that referenced
this pull request
Jul 7, 2023
* Add password message to /dashboardsinfo endpoint Signed-off-by: Craig Perkins <cwperx@amazon.com> * Update test names Signed-off-by: Craig Perkins <cwperx@amazon.com> --------- Signed-off-by: Craig Perkins <cwperx@amazon.com> (cherry picked from commit 47c4feb) Co-authored-by: Craig Perkins <cwperx@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Companion Security Dashboards Plugin PR: opensearch-project/security-dashboards-plugin#1503
This modifies the /dashboardsinfo endpoint to include the
plugins.security.restapi.password_validation_error_messagesetting or the default message of "Password should be at least 8 characters long and contain at least one uppercase letter, one lowercase letter, one digit, and one special character.". The purpose of adding this to the endpoint is to utilize this message when rendering both the password edit component and password reset component to include the proper message.Bug Fix
Issues Resolved
opensearch-project/security-dashboards-plugin#1501
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.