Update dlic auth http package#2813
Closed
stephen-crawford wants to merge 5 commits intoopensearch-project:mainfrom
Closed
Update dlic auth http package#2813stephen-crawford wants to merge 5 commits intoopensearch-project:mainfrom
stephen-crawford wants to merge 5 commits intoopensearch-project:mainfrom
Conversation
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Stephen Crawford <steecraw@amazon.com>
Signed-off-by: Stephen Crawford <steecraw@amazon.com>
Signed-off-by: Stephen Crawford <steecraw@amazon.com>
Signed-off-by: Stephen Crawford <steecraw@amazon.com>
stephen-crawford
requested review from
DarshitChanpura,
RyanL1997,
cliu123,
cwperks,
davidlago,
peternied and
reta
as code owners
11 tasks
Codecov Report
@@ Coverage Diff @@
## main #2813 +/- ##
=========================================
Coverage 61.48% 61.48%
- Complexity 3401 3402 +1
=========================================
Files 266 266
Lines 18865 18878 +13
Branches 3302 3299 -3
=========================================
+ Hits 11599 11607 +8
- Misses 5669 5675 +6
+ Partials 1597 1596 -1
|
Member
DarshitChanpura
left a comment
DarshitChanpura
left a comment
There was a problem hiding this comment.
Great work adding this formatter @scrawfor99 ! This should make future code-reviews more focused on content and less on nits :D
| <setting id="org.eclipse.jdt.core.formatter.insert_space_after_opening_paren_in_annotation" value="do not insert"/> | ||
| <setting id="org.eclipse.jdt.core.formatter.insert_space_before_opening_paren_in_switch" value="insert"/> | ||
| </profile> | ||
| </profiles> No newline at end of file |
Member
There was a problem hiding this comment.
very detailed formatter doc. Is this a standard that other repos follow?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follows: #2812
Updates formatting for Java files under
*/dlic.auth.httpCheck List
New functionality includes testingBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.