Skip to content

[Backport 2.7] Manual Backport of Dynamic tenancy configurations#2693

Merged
RyanL1997 merged 7 commits intoopensearch-project:2.7from
stephen-crawford:backport-tenancy
Apr 18, 2023
Merged

[Backport 2.7] Manual Backport of Dynamic tenancy configurations#2693
RyanL1997 merged 7 commits intoopensearch-project:2.7from
stephen-crawford:backport-tenancy

Conversation

@stephen-crawford
Copy link
Contributor

Manually backports #2607

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

abhivka7 and others added 2 commits April 17, 2023 17:38
Signed-off-by: Stephen Crawford <steecraw@amazon.com>
Signed-off-by: Abhi Kalra <abhivka@amazon.com>
Co-authored-by: Abhi Kalra <abhivka@amazon.com>
Signed-off-by: Stephen Crawford <steecraw@amazon.com>
Signed-off-by: Stephen Crawford <steecraw@amazon.com>
Signed-off-by: Stephen Crawford <steecraw@amazon.com>
Signed-off-by: Stephen Crawford <steecraw@amazon.com>
Signed-off-by: Stephen Crawford <steecraw@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Apr 17, 2023

Codecov Report

Attention: Patch coverage is 76.13636% with 42 lines in your changes missing coverage. Please review.

Project coverage is 61.30%. Comparing base (f7deb94) to head (042690e).
Report is 3 commits behind head on 2.7.

Files with missing lines Patch % Lines
.../action/tenancy/TenancyConfigRetrieveResponse.java 54.16% 11 Missing ⚠️
...ity/action/tenancy/TenancyConfigUpdateRequest.java 64.00% 8 Missing and 1 partial ⚠️
...on/tenancy/TenancyConfigUpdateTransportAction.java 82.97% 7 Missing and 1 partial ⚠️
...earch/security/dlic/rest/api/MigrateApiAction.java 0.00% 5 Missing ⚠️
...ensearch/security/action/tenancy/EmptyRequest.java 60.00% 2 Missing ⚠️
...urity/action/tenancy/TenancyConfigRestHandler.java 77.77% 1 Missing and 1 partial ⚠️
...ch/security/securityconf/DynamicConfigModelV6.java 0.00% 2 Missing ⚠️
...arch/security/dlic/rest/api/AbstractApiAction.java 83.33% 1 Missing ⚠️
...earch/security/privileges/PrivilegesEvaluator.java 66.66% 0 Missing and 1 partial ⚠️
...search/security/securityconf/impl/v7/ConfigV7.java 80.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.7    #2693      +/-   ##
============================================
+ Coverage     61.19%   61.30%   +0.11%     
- Complexity     3260     3308      +48     
============================================
  Files           259      268       +9     
  Lines         18183    18336     +153     
  Branches       3234     3242       +8     
============================================
+ Hits          11127    11241     +114     
- Misses         5488     5522      +34     
- Partials       1568     1573       +5     
Files with missing lines Coverage Δ
.../opensearch/security/OpenSearchSecurityPlugin.java 80.20% <100.00%> (+0.11%) ⬆️
...y/action/tenancy/TenancyConfigRetrieveActions.java 100.00% <100.00%> (ø)
.../tenancy/TenancyConfigRetrieveTransportAction.java 100.00% <100.00%> (ø)
...rity/action/tenancy/TenancyConfigUpdateAction.java 100.00% <100.00%> (ø)
...search/security/action/tenancy/TenancyConfigs.java 100.00% <100.00%> (ø)
...urity/configuration/PrivilegesInterceptorImpl.java 53.75% <100.00%> (+2.46%) ⬆️
...earch/security/dlic/rest/api/AccountApiAction.java 82.35% <100.00%> (ø)
...rch/security/dlic/rest/api/AllowlistApiAction.java 74.19% <100.00%> (ø)
...security/dlic/rest/api/InternalUsersApiAction.java 83.78% <100.00%> (ø)
...rity/dlic/rest/api/PatchableResourceApiAction.java 85.00% <100.00%> (ø)
... and 16 more

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@RyanL1997 RyanL1997 changed the title [Backport 2.7] Manual backport of tenancy changes [Backport 2.7] Manual Backport of Dynamic tenancy configurations Apr 18, 2023
@RyanL1997 RyanL1997 merged commit fdd3251 into opensearch-project:2.7 Apr 18, 2023
RyanL1997 pushed a commit to RyanL1997/security that referenced this pull request Apr 18, 2023
…nsearch-project#2693)

* Manual Backport of Dynamic tenancy configurations
Signed-off-by: Stephen Crawford <steecraw@amazon.com>
Signed-off-by: Abhi Kalra <abhivka@amazon.com>
RyanL1997 added a commit that referenced this pull request Apr 18, 2023
…) (#2696)

* Manual Backport of Dynamic tenancy configurations
Signed-off-by: Stephen Crawford <steecraw@amazon.com>
Signed-off-by: Abhi Kalra <abhivka@amazon.com>

Co-authored-by: Stephen Crawford <65832608+scrawfor99@users.noreply.github.com>
@stephen-crawford stephen-crawford deleted the backport-tenancy branch April 25, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants