Skip to content

Revert "Rest admin permissions (#2411) (#2466)"#2636

Merged
peternied merged 1 commit intoopensearch-project:2.xfrom
willyborankin:revert-radmin
Apr 4, 2023
Merged

Revert "Rest admin permissions (#2411) (#2466)"#2636
peternied merged 1 commit intoopensearch-project:2.xfrom
willyborankin:revert-radmin

Conversation

@willyborankin
Copy link
Collaborator

@willyborankin willyborankin commented Apr 3, 2023

Description

This PR reverts REST admin permission feature due to additional testing it needs to pass through.

Issues Resolved

Resolved #2633

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…project#2466)"

This reverts commit 076715d.

Signed-off-by: Andrey Pleskach <ples@aiven.io>
@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2023

Codecov Report

Attention: Patch coverage is 77.41935% with 28 lines in your changes missing coverage. Please review.

Project coverage is 61.06%. Comparing base (7356d9e) to head (bd17756).
Report is 623 commits behind head on 2.x.

Files with missing lines Patch % Lines
.../security/ssl/rest/SecuritySSLCertsInfoAction.java 61.11% 13 Missing and 8 partials ⚠️
...ecurity/ssl/rest/SecuritySSLReloadCertsAction.java 85.10% 4 Missing and 3 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #2636      +/-   ##
============================================
- Coverage     61.25%   61.06%   -0.20%     
+ Complexity     3310     3251      -59     
============================================
  Files           258      258              
  Lines         18272    18147     -125     
  Branches       3251     3233      -18     
============================================
- Hits          11193    11081     -112     
+ Misses         5503     5493      -10     
+ Partials       1576     1573       -3     
Files with missing lines Coverage Δ
.../opensearch/security/OpenSearchSecurityPlugin.java 79.95% <100.00%> (+0.08%) ⬆️
...arch/security/dlic/rest/api/AbstractApiAction.java 76.09% <100.00%> (-0.08%) ⬇️
...earch/security/dlic/rest/api/AccountApiAction.java 82.35% <ø> (+1.19%) ⬆️
.../security/dlic/rest/api/ActionGroupsApiAction.java 88.46% <100.00%> (+2.35%) ⬆️
...rch/security/dlic/rest/api/AllowlistApiAction.java 74.19% <ø> (-0.81%) ⬇️
...nsearch/security/dlic/rest/api/AuditApiAction.java 63.82% <ø> (-0.76%) ⬇️
...curity/dlic/rest/api/AuthTokenProcessorAction.java 57.14% <ø> (+3.80%) ⬆️
...rg/opensearch/security/dlic/rest/api/Endpoint.java 100.00% <100.00%> (ø)
...ch/security/dlic/rest/api/FlushCacheApiAction.java 63.33% <ø> (+2.04%) ⬆️
...security/dlic/rest/api/InternalUsersApiAction.java 83.78% <ø> (-0.22%) ⬇️
... and 16 more

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@peternied peternied merged commit 80961bd into opensearch-project:2.x Apr 4, 2023
@willyborankin willyborankin deleted the revert-radmin branch May 22, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants