[Backport 1.3] Add plugin install workflow and action #2300
[Backport 1.3] Add plugin install workflow and action #2300peternied merged 5 commits intoopensearch-project:1.3from
Conversation
Signed-off-by: Stephen Crawford <steecraw@amazon.com>
Signed-off-by: Stephen Crawford <steecraw@amazon.com>
Signed-off-by: Stephen Crawford <steecraw@amazon.com>
Signed-off-by: Stephen Crawford <steecraw@amazon.com>
| if: ${{ runner.os == 'Windows' }} | ||
| with: | ||
| url: https://artifacts.opensearch.org/snapshots/core/opensearch/${{ inputs.opensearch-version }}-SNAPSHOT/opensearch-min-${{ inputs.opensearch-version }}-SNAPSHOT-windows-x64-latest.zip | ||
|
|
There was a problem hiding this comment.
Could you please remove this extra line?
There was a problem hiding this comment.
I'd rather we don't attempt to review/update style comments in pull requests like number of blank lines. If you'd like to see a type of style enforced - I'd look into a tool that can enforce/correct the style towards a preference.
Checkout actions in the github marketplace [1] that could prettify/lint yml.
[1] https://github.com/marketplace/actions/yaml-lint
There was a problem hiding this comment.
Should I remove it or leave it? I can do either.
| if: ${{ runner.os == 'Windows' }} | ||
| with: | ||
| url: https://artifacts.opensearch.org/snapshots/core/opensearch/${{ inputs.opensearch-version }}-SNAPSHOT/opensearch-min-${{ inputs.opensearch-version }}-SNAPSHOT-windows-x64-latest.zip | ||
|
|
There was a problem hiding this comment.
I'd rather we don't attempt to review/update style comments in pull requests like number of blank lines. If you'd like to see a type of style enforced - I'd look into a tool that can enforce/correct the style towards a preference.
Checkout actions in the github marketplace [1] that could prettify/lint yml.
[1] https://github.com/marketplace/actions/yaml-lint
cwperks
changed the title
|
@cwperks @peternied can this be merged if we are leaving the line? |
|
Changed the branch protections to now make the |
|
As soon as the option to merge is green you can merge, no matter any outstanding comments. Conversely, if there are any changes maintainers would like before a PR is merged they should use 'Request Changes' to ensure that gets resolved before the code goes in. |
|
@scrawfor99 Should this change be backported to the 2.x line as well? I only see it in main and 1.3 now. |
4 participants
Signed-off-by: Stephen Crawford steecraw@amazon.com
Description
Backport the plugin install workflow and github action to 1.3. The backport got missed when everything else was merged into one branch.
Backports merged PR #2271 to 1.3 branch.
Testing
Tested for functionality on Java and Windows with JDK 8, 11, 14. It is worth noting that the plugin install workflow seems slightly flaky on jdk 11 alone. I encountered this issue first when I was originally merging PR #2271. For whatever reason the setup.bat file does not always echo the 'yes' response into the install script as expected. It passes over 50% of the time though.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.