[BACKPORT] Backports Plugin Install Workflow and action for windows#2288
Closed
stephen-crawford wants to merge 18 commits intoopensearch-project:1.3from
Closed
[BACKPORT] Backports Plugin Install Workflow and action for windows#2288stephen-crawford wants to merge 18 commits intoopensearch-project:1.3from
stephen-crawford wants to merge 18 commits intoopensearch-project:1.3from
Conversation
Signed-off-by: Stephen Crawford <steecraw@amazon.com>
Signed-off-by: Stephen Crawford <steecraw@amazon.com>
Signed-off-by: Stephen Crawford <steecraw@amazon.com>
Signed-off-by: Stephen Crawford <steecraw@amazon.com>
Signed-off-by: Stephen Crawford <steecraw@amazon.com>
Signed-off-by: Stephen Crawford <steecraw@amazon.com>
Signed-off-by: Stephen Crawford <steecraw@amazon.com>
cwperks
reviewed
Dec 1, 2022
Signed-off-by: Stephen Crawford <steecraw@amazon.com>
Codecov Report
@@ Coverage Diff @@
## 1.3 #2288 +/- ##
============================================
+ Coverage 64.59% 64.73% +0.14%
- Complexity 3223 3226 +3
============================================
Files 247 247
Lines 17376 17377 +1
Branches 3088 3097 +9
============================================
+ Hits 11224 11249 +25
+ Misses 4593 4578 -15
+ Partials 1559 1550 -9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Member
@scrawfor99 Please reach out to the Engineering Effectiveness team to get help finding the min distro |
3 tasks
peternied
suggested changes
Dec 1, 2022
Member
peternied
left a comment
peternied
left a comment
There was a problem hiding this comment.
Seems like this is still in draft while getting the windows min build, want to make that switch? Note; I think it might be more useful to lump the changes for the plugin install workflow into a single PR that we approve at once rather than one at a time
.github/workflows/plugin_install.yml
Outdated
Comment on lines
36
to
42
| ls | ||
| cd build | ||
| echo at $(pwd) | ||
| ls | ||
| cd distributions | ||
| echo at $(pwd) | ||
| ls |
Contributor
Author
There was a problem hiding this comment.
Oops will remove.
3 tasks
Signed-off-by: Peter Nied <petern@amazon.com>
Signed-off-by: Peter Nied <petern@amazon.com>
Signed-off-by: Peter Nied <petern@amazon.com>
Add CI for Windows and MacOS platforms Due to the increase in the number of platforms, I've separated the newer integration tests into their own workflow. Until retries have been enabled they will automatically pass - but still run and report logs. As soon as we have full confidence we will allow them to start blocking pull requests from merging. opensearch-project#2184 Switch the gradle commands to be platform agnostic via the `gradle/gradle-build-action@v2`, dropping the 'clean' step to the build which allows us to reuse the gradle cache - if we see any problems pulling in more recent snapshots we can disable this setting quickly. Found and fixed an issued with config value replacement via environment variables, long story short Windows and MacOS allow for many more characters that are used in the unix environment variable landscape. Added new tests to cover these interesting scenarios as well. Found an encoding issue with user names from config files, still unclear of the source of this issue, be it test setup specific or a problem in the broader OpenSearch ecosystem, disabling the `testSpecialUsernames` until we can dive deeper. opensearch-project#2194 Disabled the HeapBasedRateTrackerTests - it was depending on system timing and was very brittle if the system under test experienced any undo load, created follow up issue opensearch-project#2193 Fixed a test issue in testDlsWithMinDocCountZeroAggregations where there was a random chance for a test failure, easier to find intermittent tests when they are run so often. OpenSSL has open questions - while it is supported for our Linux JDK11 builds, it seems like a stopgap measure. I've disabled the tests on windows environment while we determine if we should support OpenSSL at all on Windows JDK11. opensearch-project#2195 Signed-off-by: Peter Nied <petern@amazon.com>
Adds spotbugs [1] to detect internalization before they are added to the codebase, also fixed several encoding bugs that impact windows users. [1] https://spotbugs.readthedocs.io/en/stable/index.html Closes opensearch-project#2194 Signed-off-by: Peter Nied <petern@amazon.com>
Signed-off-by: Peter Nied <petern@amazon.com>
Signed-off-by: Peter Nied <petern@amazon.com>
Signed-off-by: Stephen Crawford <steecraw@amazon.com>
Contributor
Author
|
I rebased onto your branch and then PR'd against it. I am reaching out to the Engineering Effectiveness team now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backports the plugin_install workflow and associated action.
Backports PR #2271
Successfully ran CI and Plugin Install for Linux runner. Windows cannot be tested further until there is a Windows Min. Distribution available.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.