Tenant Permissions : added the possibility to specify tenants via parameter#1813
Merged
peternied merged 5 commits intoopensearch-project:mainfrom Jun 7, 2022
Merged
Conversation
…ity to specify tenants via parameter substitution. Signed-off-by: Christophe Chazeau <christophe.chazeau@gmail.com>
…ions Signed-off-by: Christophe Chazeau <christophe.chazeau@gmail.com>
Following some of the practices discussed on this project I've made several modifications to the scenario tests that were added to ensure readiablity and maintainability. Used this as an exercise to be more familiar with the tenant parameter based substitution. Signed-off-by: Peter Nied <petern@amazon.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1813 +/- ##
============================================
+ Coverage 60.87% 60.90% +0.02%
- Complexity 3215 3216 +1
============================================
Files 256 256
Lines 18012 18019 +7
Branches 3211 3213 +2
============================================
+ Hits 10965 10974 +9
+ Misses 5467 5464 -3
- Partials 1580 1581 +1
🚀 New features to boost your workflow:
|
DarshitChanpura
previously approved these changes
May 2, 2022
cliu123
reviewed
May 9, 2022
src/test/java/org/opensearch/security/multitenancy/test/MultitenancyTests.java
Show resolved
Hide resolved
Member
Author
|
@cliu123 Did you have any other comments around this pull request that need to be addressed? |
cliu123
approved these changes
May 17, 2022
cliu123
reviewed
May 17, 2022
cliu123
requested changes
May 17, 2022
Member
cliu123
left a comment
There was a problem hiding this comment.
Most of the changes look great to me! I missed the do...while in last review though. This can be merged when it gets fixed.
Signed-off-by: Peter Nied <petern@amazon.com>
cliu123
previously approved these changes
May 27, 2022
…itutions Signed-off-by: Peter Nied <petern@amazon.com>
26e348b to
75ccda8
Compare
Member
Author
|
@DarshitChanpura @cliu123 could I get another review? |
cliu123
approved these changes
Jun 2, 2022
DarshitChanpura
approved these changes
Jun 7, 2022
stephen-crawford
pushed a commit
to stephen-crawford/security
that referenced
this pull request
Nov 10, 2022
…ameter (opensearch-project#1813) * Issue opensearch-project#817 : Tenant Permissions, added the possibility to specify tenants via parameter substitution. Signed-off-by: Christophe Chazeau <christophe.chazeau@gmail.com> Co-authored-by: Peter Nied <petern@amazon.com> Signed-off-by: Stephen Crawford <steecraw@amazon.com>
wuychn
pushed a commit
to ochprince/security
that referenced
this pull request
Mar 16, 2023
…ameter (opensearch-project#1813) * Issue opensearch-project#817 : Tenant Permissions, added the possibility to specify tenants via parameter substitution. Signed-off-by: Christophe Chazeau <christophe.chazeau@gmail.com> Co-authored-by: Peter Nied <petern@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a continuation of #819 with many thanks to @chrousto
The idea would be that this user :
Would only have access to the tenant tenant1 if the role role-tenant1 was defined like this :
Issues Resolved
Testing
Integration tests have been created for this feature
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.