Skip to content

Add CI check for demo script#1690

Merged
peternied merged 5 commits intoopensearch-project:mainfrom
peternied:demo-script-test
Mar 23, 2022
Merged

Add CI check for demo script#1690
peternied merged 5 commits intoopensearch-project:mainfrom
peternied:demo-script-test

Conversation

@peternied
Copy link
Copy Markdown
Member

Description

Added a new check to build, install, and run the security plugin with the demo configuration script.

This was built heavily borrowing from https://github.com/opensearch-project/security-dashboards-plugin/blob/main/.github/workflows/integration-test.yml

Issues Resolved

Testing

Automatically runs as part of PR and PUSH Github actions

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@peternied peternied added the enhancement New feature or request label Mar 21, 2022
@peternied peternied requested a review from a team March 21, 2022 20:55
@peternied peternied self-assigned this Mar 21, 2022
@peternied
Copy link
Copy Markdown
Member Author

Hit a failure due to version mismatch where we updated a jar version that is behind in the distribution

Caused by: java.lang.IllegalStateException: jar hell!
class: com.fasterxml.jackson.dataformat.cbor.CBORConstants
jar1: /opensearch/plugins/.installing-15168128924324[135](https://github.com/peternied/security/runs/5634491143?check_suite_focus=true#step:11:135)285/jackson-dataformat-cbor-2.13.2.jar
jar2: /opensearch/lib/jackson-dataformat-cbor-2.12.6.jar
	at org.opensearch.bootstrap.JarHell.checkClass(JarHell.java:317)
	at org.opensearch.bootstrap.JarHell.checkJarHell(JarHell.java:212)
	at org.opensearch.plugins.PluginsService.checkBundleJarHell(PluginsService.java:676)
	... 11 more

@peternied peternied added the backport 1.x backport to 1.x branch label Mar 21, 2022
@cliu123
Copy link
Copy Markdown
Member

cliu123 commented Mar 21, 2022

Good contribution! Looking forward to this!

@peternied
Copy link
Copy Markdown
Member Author

This change is blocked on opensearch-project/OpenSearch#2544 getting merged

@peternied peternied removed the backport 1.x backport to 1.x branch label Mar 21, 2022
Comment thread .github/workflows/plugin_install.yml
@cliu123
Copy link
Copy Markdown
Member

cliu123 commented Mar 22, 2022

One of the tasks failed.

Run curl -XGET https://localhost:[9](https://github.com/opensearch-project/security/runs/5634568266?check_suite_focus=true#step:10:9)200 -u 'admin:admin' -k -v
Note: Unnecessary use of -X or --request, GET is already inferred.

Comment thread .github/workflows/plugin_install.yml Outdated
Comment thread .github/workflows/plugin_install.yml
Comment thread .github/workflows/plugin_install.yml
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 22, 2022

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.90%. Comparing base (2e1da49) to head (7582c8d).
⚠️ Report is 1516 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1690      +/-   ##
============================================
+ Coverage     62.89%   62.90%   +0.01%     
- Complexity     3259     3260       +1     
============================================
  Files           253      253              
  Lines         18087    18087              
  Branches       3255     3255              
============================================
+ Hits          11375    11377       +2     
+ Misses         5063     5062       -1     
+ Partials       1649     1648       -1     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Peter Nied <petern@amazon.com>
Signed-off-by: Peter Nied <petern@amazon.com>
Signed-off-by: Peter Nied <petern@amazon.com>
Signed-off-by: Peter Nied <petern@amazon.com>
Signed-off-by: Peter Nied <petern@amazon.com>
Comment thread build.gradle
@peternied peternied merged commit b1e2b9d into opensearch-project:main Mar 23, 2022
Comment thread .github/workflows/plugin_install.yml
@peternied peternied deleted the demo-script-test branch March 23, 2022 19:29
wuychn pushed a commit to ochprince/security that referenced this pull request Mar 16, 2023
Signed-off-by: Peter Nied <petern@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Automate checking of the security plugin installation

5 participants