Add CI check for demo script#1690
Merged
peternied merged 5 commits intoopensearch-project:mainfrom Mar 23, 2022
Merged
Conversation
Member
Author
|
Hit a failure due to version mismatch where we updated a jar version that is behind in the distribution |
Member
|
Good contribution! Looking forward to this! |
Member
Author
|
This change is blocked on opensearch-project/OpenSearch#2544 getting merged |
cliu123
reviewed
Mar 22, 2022
Member
|
One of the tasks failed. |
cliu123
reviewed
Mar 22, 2022
cliu123
reviewed
Mar 22, 2022
cliu123
reviewed
Mar 22, 2022
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1690 +/- ##
============================================
+ Coverage 62.89% 62.90% +0.01%
- Complexity 3259 3260 +1
============================================
Files 253 253
Lines 18087 18087
Branches 3255 3255
============================================
+ Hits 11375 11377 +2
+ Misses 5063 5062 -1
+ Partials 1649 1648 -1 🚀 New features to boost your workflow:
|
Signed-off-by: Peter Nied <petern@amazon.com>
Signed-off-by: Peter Nied <petern@amazon.com>
Signed-off-by: Peter Nied <petern@amazon.com>
Signed-off-by: Peter Nied <petern@amazon.com>
Signed-off-by: Peter Nied <petern@amazon.com>
1b1a3b5 to
7582c8d
Compare
davidlago
approved these changes
Mar 23, 2022
DarshitChanpura
approved these changes
Mar 23, 2022
cliu123
reviewed
Mar 23, 2022
wuychn
pushed a commit
to ochprince/security
that referenced
this pull request
Mar 16, 2023
Signed-off-by: Peter Nied <petern@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added a new check to build, install, and run the security plugin with the demo configuration script.
This was built heavily borrowing from https://github.com/opensearch-project/security-dashboards-plugin/blob/main/.github/workflows/integration-test.yml
Issues Resolved
Testing
Automatically runs as part of PR and PUSH Github actions
Check List
New functionality includes testingNew functionality has been documentedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.