Backwards Compatibility Tests Draft#1666
Closed
peternied wants to merge 7 commits intoopensearch-project:mainfrom
Closed
Backwards Compatibility Tests Draft#1666peternied wants to merge 7 commits intoopensearch-project:mainfrom
peternied wants to merge 7 commits intoopensearch-project:mainfrom
Conversation
BWC tooling is built with gradle 6, which has breaking changes that are not compatiable with gradle 7. In order to support BWC tests we need to align with the OpenSearch's gradle version for the 1.3 release. See Also: * Gradle 7 PR in OpenSearch opensearch-project/OpenSearch#1622 * Distribution build bugs encountered by plugins opensearch-project/opensearch-build#1247 * Revert of Gradle 7 PR in OpenSearch opensearch-project/OpenSearch#1657 Signed-off-by: Peter Nied <petern@amazon.com>
Following example from: opensearch-project/common-utils#121 Signed-off-by: Peter Nied <petern@amazon.com>
Signed-off-by: Peter Nied <petern@amazon.com>
Signed-off-by: Peter Nied <petern@amazon.com>
…ssion syntax Signed-off-by: Peter Nied <petern@amazon.com>
Signed-off-by: Peter Nied <petern@amazon.com>
Using opensearch-project/anomaly-detection#158 as a template, created those changes as a seperate gradle file. Gradlew execution of tests has been implemented, but untested. The tests themselves have been started but do not have the actual security plugin setup/validation logic that we would like to use. Scan for TODO within the files. Signed-off-by: Peter Nied <petern@amazon.com>
Member
Author
|
NOTE: This pull request is not intended to be merged, its but serves as a starting point for taking these tests across the finish line. |
peternied
changed the title
Member
@peternied Looks like this PR is changing the existing |
| String baseName = "securityBwcCluster" | ||
| String bwcFilePath = "src/test/resources/bwc" | ||
|
|
||
| 2.times {i -> |
Member
There was a problem hiding this comment.
can you add a comment here please explaining why we need two clusters here (just like you did below)
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Using opensearch-project/anomaly-detection#158 as a template.
Gradlew execution of tests has been implemented, but untested. The
tests themselves have been started but do not have the actual security
plugin setup/validation logic that we would like to use. Scan for TODO
within the files.
NOTE: Final commit 75bc096 should be under consideration, all other changes were needed for the gradle downgrade, in #1661
Approximant guess of
Issues Resolved
Check List
New functionality includes testingBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.