Skip to content

Remove github DCO action as it has been replaced with a github app#1656

Merged
peternied merged 1 commit intoopensearch-project:mainfrom
peternied:remove-dco-classic
Mar 2, 2022
Merged

Remove github DCO action as it has been replaced with a github app#1656
peternied merged 1 commit intoopensearch-project:mainfrom
peternied:remove-dco-classic

Conversation

@peternied
Copy link
Member

Description

Remove github DCO action as it has been replaced with a github app

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Peter Nied <petern@amazon.com>
@peternied peternied requested a review from a team March 2, 2022 16:37
@peternied peternied self-assigned this Mar 2, 2022
@peternied peternied added the backport 1.3 backport to 1.3 branch label Mar 2, 2022
@peternied
Copy link
Member Author

Adding backport to 1.3 as active development work will still be happening in that branch

@codecov-commenter
Copy link

codecov-commenter commented Mar 2, 2022

Codecov Report

Merging #1656 (00fa756) into main (3638c6f) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1656      +/-   ##
============================================
- Coverage     64.63%   64.59%   -0.05%     
+ Complexity     3218     3215       -3     
============================================
  Files           247      247              
  Lines         17352    17352              
  Branches       3082     3082              
============================================
- Hits          11216    11209       -7     
- Misses         4588     4594       +6     
- Partials       1548     1549       +1     
Impacted Files Coverage Δ
...security/auditlog/sink/ExternalOpenSearchSink.java 59.25% <0.00%> (-2.47%) ⬇️
...ecurity/configuration/ConfigurationRepository.java 73.07% <0.00%> (-2.20%) ⬇️
...a/org/opensearch/security/tools/SecurityAdmin.java 47.59% <0.00%> (-0.27%) ⬇️
...search/security/transport/SecurityInterceptor.java 74.78% <0.00%> (+0.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3638c6f...00fa756. Read the comment docs.

@peternied peternied merged commit 0b63577 into opensearch-project:main Mar 2, 2022
@peternied
Copy link
Member Author

Note; I've also update the branch protection rules inline with these changes

@peternied peternied deleted the remove-dco-classic branch March 2, 2022 18:22
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 2, 2022
…1656)

Signed-off-by: Peter Nied <petern@amazon.com>
(cherry picked from commit 0b63577)
peternied added a commit that referenced this pull request Mar 2, 2022
…1656) (#1657)

Signed-off-by: Peter Nied <petern@amazon.com>
(cherry picked from commit 0b63577)

Co-authored-by: Peter Nied <petern@amazon.com>
wuychn pushed a commit to ochprince/security that referenced this pull request Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 1.3 backport to 1.3 branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants