Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 6 additions & 11 deletions .github/workflows/integration-test.yml
Original file line number Diff line number Diff line change
@@ -1,12 +1,6 @@
name: Integration Tests

on:
pull_request:
branches:
- main
push:
branches:
- main
on: [push, pull_request]

jobs:
tests:
Expand All @@ -15,12 +9,13 @@ jobs:
steps:
- name: Download OpenSearch Core
run: |
wget https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/1.3.0/488/linux/x64/builds/opensearch/dist/opensearch-min-1.3.0-linux-x64.tar.gz
wget https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/2.0.0-alpha1/latest/linux/x64/builds/opensearch/dist/opensearch-min-2.0.0-alpha1-linux-x64.tar.gz
tar -xzf opensearch-*.tar.gz
rm -f opensearch-*.tar.gz

- name: Download OpenSearch Security Plugin
run: wget -O opensearch-security.zip https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/1.3.0/488/linux/x64/builds/opensearch/plugins/opensearch-security-1.3.0.0.zip
run: wget -O opensearch-security.zip https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/2.0.0-alpha1/latest/linux/x64/builds/opensearch/plugins/opensearch-security-2.0.0.0-alpha1.zip


- name: Run OpenSearch with plugin
run: |
Expand Down Expand Up @@ -50,7 +45,7 @@ jobs:
with:
path: OpenSearch-Dashboards
repository: opensearch-project/OpenSearch-Dashboards
ref: '1.x'
ref: 'main'
fetch-depth: 0

- name: Create plugins dir
Expand Down
11 changes: 2 additions & 9 deletions .github/workflows/unit-test.yml
Original file line number Diff line number Diff line change
@@ -1,13 +1,6 @@
name: Unit Tests

on:
pull_request:
branches:
- main
- 1.*
push:
branches:
- main
on: [push, pull_request]

jobs:
tests:
Expand All @@ -20,7 +13,7 @@ jobs:
with:
path: OpenSearch-Dashboards
repository: opensearch-project/OpenSearch-Dashboards
ref: '1.x'
ref: 'main'
fetch-depth: 0
- name: Create plugins dir
run: |
Expand Down
File renamed without changes.
3 changes: 2 additions & 1 deletion common/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -44,5 +44,6 @@ export enum AuthType {
*/
export function isValidResourceName(resourceName: string): boolean {
// see: https://javascript.info/regexp-unicode
return !/[\p{C}%]/u.test(resourceName) && resourceName.length > 0;
const exp = new RegExp('[\\p{C}%]', 'u');
return !exp.test(resourceName) && resourceName.length > 0;
}
4 changes: 2 additions & 2 deletions opensearch_dashboards.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"id": "securityDashboards",
"version": "1.3.0.0",
"opensearchDashboardsVersion": "1.3.0",
"version": "2.0.0.0",
"opensearchDashboardsVersion": "2.0.0",
"configPath": ["opensearch_security"],
"requiredPlugins": ["navigation"],
"server": true,
Expand Down
16 changes: 8 additions & 8 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
{
"name": "opensearch-security-dashboards",
"version": "1.3.0.0",
"version": "2.0.0.0",
"main": "target/plugins/opensearch_security_dashboards",
"opensearchDashboards": {
"version": "1.3.0",
"templateVersion": "1.3.0"
"version": "2.0.0",
"templateVersion": "2.0.0"
},
"license": "Apache-2.0",
"homepage": "https://github.com/opensearch-project/security-dashboards-plugin",
Expand All @@ -15,20 +15,20 @@
"build": "yarn plugin-helpers build && node build_tools/rename_zip.js",
"start": "node ../../scripts/opensearch-dashboards --dev",
"lint:es": "node ../../scripts/eslint",
"lint:sass": "node ../../scripts/sasslint",
"lint": "yarn run lint:es && yarn run lint:sass",
"lint:style": "node ../../scripts/stylelint",
"lint": "yarn run lint:es && yarn run lint:style",
"test:jest_server": "node ./test/run_jest_tests.js --config ./test/jest.config.server.js",
"test:jest_ui": "node ./test/run_jest_tests.js --config ./test/jest.config.ui.js"
},
"devDependencies": {
"@elastic/eslint-import-resolver-kibana": "link:../../packages/osd-eslint-import-resolver-opensearch-dashboards",
"@elastic/eslint-import-resolver-kibana": "link:../../packages/osd-eslint-import-resolver-opensearch-dashboards",
"typescript": "4.0.2",
"gulp-rename": "2.0.0",
"@testing-library/react-hooks": "^3.4.1",
"@testing-library/react-hooks": "^7.0.2",
"@types/hapi__wreck": "^15.0.1"
},
"dependencies": {
"@hapi/wreck": "^15.0.2",
"@hapi/wreck": "^17.1.0",
"@hapi/cryptiles": "5.0.0",
"html-entities": "1.3.1"
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ exports[`Account navigation button renders 1`] = `
id="actionsMenu"
isOpen={false}
onClick={[Function]}
ownFocus={false}
ownFocus={true}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe this was asked before, but why this change?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is because the unit test were failing due to jest snapshot mismatch... this is something worth the discussion.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note, this control was likely modified by a change in the styles from OpenSearch-Dashboards. We should follow up and confirm that our UI looks clean and behaves as expected between 1.3.X and this 2.0.0 version.

I've created #938 for following up on this.

panelPaddingSize="s"
>
<EuiContextMenuPanel
Expand Down
16 changes: 8 additions & 8 deletions public/apps/configuration/_index.scss
Original file line number Diff line number Diff line change
Expand Up @@ -13,31 +13,31 @@
* permissions and limitations under the License.
*/

.panel-header-count {
color: #687078;
font-weight: normal;
.panel-header-count {
color: #687078;
font-weight: normal;
}

.panel-header-subtext {
width: 75%;
width: 75%;
}

.text-center {
text-align: 'center'
text-align: "center";
}

.panel-restrict-width {
max-width: 75%;
max-width: 75%;
}

.external-link-inline-block {
display: inline-block;
}

.table-items {
font-size: inherit;
font-size: inherit;
}

.limit-width-input {
max-width: 400px;
max-width: 400px;
}
6 changes: 3 additions & 3 deletions public/apps/configuration/panels/audit-logging/_index.scss
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
.described-form-group {
max-width: 1500px
max-width: 1500px;
}

.form-row {
max-width: 800px
max-width: 800px;
}

pre code {
color: #666666;
color: #666;
}
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

.permission-tree-container {
max-height: 200px;
overflow-Y: scroll;
overflow-y: scroll;
width: 100%;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

exports[`Permission edit modal Submit button text should be Create when user is creating tenant 1`] = `
<EuiButtonDisplay
baseClassName="euiButton"
disabled={false}
element="button"
fill={true}
Expand All @@ -16,6 +17,7 @@ exports[`Permission edit modal Submit button text should be Create when user is

exports[`Permission edit modal Submit button text should be Save when user is updating tenant 1`] = `
<EuiButtonDisplay
baseClassName="euiButton"
disabled={false}
element="button"
fill={true}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,5 +24,11 @@ exports[`Navigation panel renders 1`] = `
},
]
}
mobileBreakpoints={
Array [
"xs",
"s",
]
}
/>
`;
8 changes: 4 additions & 4 deletions public/apps/customerror/_index.scss
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
*/

.custom-error-wrapper {
margin: 10% auto;
width: 350px;
padding: 1rem;
position: relative;
margin: 10% auto;
width: 350px;
padding: 1rem;
position: relative;
}
10 changes: 5 additions & 5 deletions public/apps/login/_index.scss
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,12 @@
*/

.login-wrapper {
margin: 10% auto;
width: 350px;
padding: 1rem;
position: relative;
margin: 10% auto;
width: 350px;
padding: 1rem;
position: relative;
}

.btn-login {
width: 100%;
width: 100%;
}
Empty file removed public/index.scss
Empty file.
3 changes: 0 additions & 3 deletions public/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,6 @@
* express or implied. See the License for the specific language governing
* permissions and limitations under the License.
*/

import './index.scss';

import { SecurityPlugin } from './plugin';
import { PluginInitializerContext } from '../../../src/core/public';

Expand Down
2 changes: 1 addition & 1 deletion server/auth/types/basic/routes.ts
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ export class BasicAuthRoutes {
? this.coreSetup.http.basePath.serverBasePath
: '/';
const requestQuery = request.url.query as ParsedUrlQueryParams;
if (requestQuery.nextUrl !== undefined) {
if (requestQuery?.nextUrl !== undefined) {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've created #936 to follow up, we should stop using the legacy url.query method

redirectUrl = requestQuery.nextUrl;
}
context.security_plugin.logger.info('The Redirect Path is ' + redirectUrl);
Expand Down