Get OPENSEARCH_VERSION from upstream package.json file#2246
Merged
cwperks merged 1 commit intoopensearch-project:mainfrom May 19, 2025
Merged
Get OPENSEARCH_VERSION from upstream package.json file#2246cwperks merged 1 commit intoopensearch-project:mainfrom
cwperks merged 1 commit intoopensearch-project:mainfrom
Conversation
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2246 +/- ##
=======================================
Coverage 72.01% 72.01%
=======================================
Files 98 98
Lines 2691 2691
Branches 420 412 -8
=======================================
Hits 1938 1938
Misses 638 638
Partials 115 115 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
derek-ho
approved these changes
May 19, 2025
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR undoes some of the changes from #2190 to get this version centrally from opensearch-dashboard's package.json file.
This PR resolves an issue seen on version increment PRs where the automation is not getting these hardcoded instances of the version.
Category
[Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation]
Maintenance
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.