Skip to content

Get OPENSEARCH_VERSION from upstream package.json file#2246

Merged
cwperks merged 1 commit intoopensearch-project:mainfrom
cwperks:get-version-from-upstream
May 19, 2025
Merged

Get OPENSEARCH_VERSION from upstream package.json file#2246
cwperks merged 1 commit intoopensearch-project:mainfrom
cwperks:get-version-from-upstream

Conversation

@cwperks
Copy link
Member

@cwperks cwperks commented May 19, 2025

Description

This PR undoes some of the changes from #2190 to get this version centrally from opensearch-dashboard's package.json file.

This PR resolves an issue seen on version increment PRs where the automation is not getting these hardcoded instances of the version.

Category

[Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation]

Maintenance

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Craig Perkins <cwperx@amazon.com>
@codecov
Copy link

codecov bot commented May 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.01%. Comparing base (391fe2f) to head (7fcfe42).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2246   +/-   ##
=======================================
  Coverage   72.01%   72.01%           
=======================================
  Files          98       98           
  Lines        2691     2691           
  Branches      420      412    -8     
=======================================
  Hits         1938     1938           
  Misses        638      638           
  Partials      115      115           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cwperks cwperks merged commit 3045637 into opensearch-project:main May 19, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants