[Main] Check in yarn.lock file in its current state and update cypress to version 13.6.0#1668
Merged
RyanL1997 merged 8 commits intoopensearch-project:mainfrom Dec 1, 2023
Merged
Conversation
Signed-off-by: Derek Ho <dxho@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1668 +/- ##
=======================================
Coverage 67.06% 67.06%
=======================================
Files 94 94
Lines 2402 2402
Branches 318 318
=======================================
Hits 1611 1611
Misses 713 713
Partials 78 78 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Derek Ho <dxho@amazon.com>
…ds-plugin into check-in-yarn
3 tasks
cwperks
previously approved these changes
Nov 28, 2023
Collaborator
|
Updating branch due to the merge of #1579 |
Signed-off-by: Ryan Liang <jiallian@amazon.com>
Collaborator
|
Hi @derek-ho, I just pushed another commit to include the latest Cypress 13 and update the yarn lock file. |
RyanL1997
approved these changes
Nov 29, 2023
cwperks
approved these changes
Dec 1, 2023
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes yarn.lock from gitignore, and checks in the current version of the generated yarn.lock file, after running yarn install. Yarn.lock provides a few benefits:
Category
[Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation]
Why these changes are required?
What is the old behavior before changes and new behavior after changes?
Issues Resolved
[List any issues this PR will resolve (Is this a backport? If so, please add backport PR # and/or commits #)]
Testing
[Please provide details of testing done: unit testing, integration testing and manual testing]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.