Fix a bad import path#1498
Merged
peternied merged 3 commits intoopensearch-project:mainfrom Jun 30, 2023
Merged
Conversation
- Resolves opensearch-project#1487 Signed-off-by: Peter Nied <petern@amazon.com> Signed-off-by: Peter Nied <peternied@hotmail.com>
49a52a3 to
947d2d7
Compare
Member
|
@peternied Please fix the eslint issue. I'm looking into how this got past CI on the offending PR. |
Signed-off-by: Peter Nied <peternied@hotmail.com>
cwperks
approved these changes
Jun 30, 2023
Codecov Report
@@ Coverage Diff @@
## main #1498 +/- ##
=======================================
Coverage 65.61% 65.61%
=======================================
Files 93 93
Lines 2309 2309
Branches 315 315
=======================================
Hits 1515 1515
Misses 726 726
Partials 68 68 |
RyanL1997
approved these changes
Jun 30, 2023
Collaborator
|
Approved. Updating the branch. |
peternied
added a commit
that referenced
this pull request
Jun 30, 2023
* Fix a bad import path - Resolves #1487 Signed-off-by: Peter Nied <petern@amazon.com> Signed-off-by: Peter Nied <peternied@hotmail.com> Co-authored-by: Ryan Liang <109499885+RyanL1997@users.noreply.github.com> (cherry picked from commit 32c02c8) Co-authored-by: Peter Nied <petern@amazon.com>
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.x 1.x
# Navigate to the new working tree
cd .worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-1498-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 32c02c8c18a509884613517fac38b684338d5273
# Push it to GitHub
git push --set-upstream origin backport/backport-1498-to-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.xThen, create a pull request where the |
peternied
added a commit
that referenced
this pull request
Aug 7, 2023
* Fix a bad import path - Resolves #1487 Signed-off-by: Peter Nied <petern@amazon.com> Signed-off-by: Peter Nied <peternied@hotmail.com> Co-authored-by: Ryan Liang <109499885+RyanL1997@users.noreply.github.com> (cherry picked from commit 32c02c8) Co-authored-by: Peter Nied <petern@amazon.com>
samuelcostae
pushed a commit
to samuelcostae/security-dashboards-plugin
that referenced
this pull request
Aug 10, 2023
* Fix a bad import path - Resolves opensearch-project#1487 Signed-off-by: Peter Nied <petern@amazon.com> Signed-off-by: Peter Nied <peternied@hotmail.com> Co-authored-by: Ryan Liang <109499885+RyanL1997@users.noreply.github.com> Signed-off-by: Sam <samuel.costa@eliatra.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Found a case where the import was done using a relative reference, instead of using a package reference causing a build break in some circumstances.
Issues Resolved
Testing
Using relative path import is fundamentally wrong, as long as CI works this fix works. Verified that there are no other references to
../packages/in the codebase as well.Check List
New functionality includes testingNew functionality has been documentedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.