[Backport 2.8] Fixing dynamic tenancy changes for issues 1412 (#1419)#1459
Closed
DarshitChanpura wants to merge 1 commit intoopensearch-project:2.8from
Closed
[Backport 2.8] Fixing dynamic tenancy changes for issues 1412 (#1419)#1459DarshitChanpura wants to merge 1 commit intoopensearch-project:2.8from
DarshitChanpura wants to merge 1 commit intoopensearch-project:2.8from
Conversation
* Fixing dynamic tenancy changes for opensearchdasbhoard.yaml Signed-off-by: Abhi Kalra <abhivka@amazon.com> Co-authored-by: Abhi Kalra <abhivka@amazon.com> Co-authored-by: Stephen Crawford <65832608+scrawfor99@users.noreply.github.com> (cherry picked from commit c4e6c37) Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Member
Author
|
Closing in lieu of #1457 |
Codecov Report
@@ Coverage Diff @@
## 2.8 #1459 +/- ##
==========================================
- Coverage 65.51% 65.47% -0.05%
==========================================
Files 93 93
Lines 2294 2297 +3
Branches 307 313 +6
==========================================
+ Hits 1503 1504 +1
- Misses 723 725 +2
Partials 68 68
|
Collaborator
|
Let's reopen it, to see which one pass the test first so that we can merge it asap. |
RyanL1997
approved these changes
May 31, 2023
Collaborator
|
Closing this one, sorry for the confusions but it seems like these versions are not for 2.8 https://github.com/opensearch-project/security-dashboards-plugin/pull/1459/files#diff-b6d8f4eded54754091348620a504858aa34db8947921abddddc018c61eb87a9cR12-R14 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #1419
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.