Fixing dynamic tenancy changes for issues 1412 (#1419)#1424
Merged
RyanL1997 merged 4 commits intoopensearch-project:2.7from May 8, 2023
Merged
Fixing dynamic tenancy changes for issues 1412 (#1419)#1424RyanL1997 merged 4 commits intoopensearch-project:2.7from
RyanL1997 merged 4 commits intoopensearch-project:2.7from
Conversation
* Fixing dynamic tenancy changes for opensearchdasbhoard.yaml Signed-off-by: Abhi Kalra <abhivka@amazon.com> Co-authored-by: Abhi Kalra <abhivka@amazon.com> Co-authored-by: Stephen Crawford <65832608+scrawfor99@users.noreply.github.com>
Signed-off-by: Abhi Kalra <abhivka@amazon.com>
Signed-off-by: Abhi Kalra <abhivka@amazon.com>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## 2.7 #1424 +/- ##
==========================================
- Coverage 65.51% 65.47% -0.05%
==========================================
Files 93 93
Lines 2294 2297 +3
Branches 312 308 -4
==========================================
+ Hits 1503 1504 +1
- Misses 723 725 +2
Partials 68 68
|
Contributor
|
@opensearch-project/security it looks like the failing SAML test is the known flaky one. I am not sure what the issue with the Cypress one is but will be unable to look given another OpenSearch commitment. I am approving this PR so that we can get this change in for the distribution. That being said, we will need to make a new issue for the failing tests at the very least and other reviewers may want to reach out to @abhivka7. |
stephen-crawford
approved these changes
May 8, 2023
cwperks
approved these changes
May 8, 2023
abhivka7
force-pushed
the
2.7
branch
3 times, most recently
from
3287a8f to
819967d
Compare
Signed-off-by: Abhi Kalra <abhivka@amazon.com>
RyanL1997
approved these changes
May 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #1419 from main to 2.7
Changing Dashboards version from 2.7.0 to 2.7.1