Fixes mutlti-tenancy popup toggle due to hard-coded default state#1417
Closed
DarshitChanpura wants to merge 1 commit intoopensearch-project:mainfrom
Closed
Fixes mutlti-tenancy popup toggle due to hard-coded default state#1417DarshitChanpura wants to merge 1 commit intoopensearch-project:mainfrom
DarshitChanpura wants to merge 1 commit intoopensearch-project:mainfrom
Conversation
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
DarshitChanpura
requested review from
RyanL1997,
cliu123,
cwperks,
davidlago,
peternied and
stephen-crawford
as code owners
seraphjiang
reviewed
May 4, 2023
| setIsMultiTenancyEnabled(isEnabled); | ||
| } catch (e) { | ||
| // TODO: switch to better error display. | ||
| console.error(e); |
Member
There was a problem hiding this comment.
we should have default behavior instead of print error into browser console which will notice nothing to customer and not actonable
Member
Author
|
Closing in lieu of #1419 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category
Bug fix
Why these changes are required?
To fix the incorrect popup display for switching tenants.
What is the old behavior before changes and new behavior after changes?
After this change the switch tenants panel and popup won't be shown if multi-tenancy is disabled.
Issues Resolved
Resolves #1412
Testing
Manual testing
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.