Skip to content

[Backport 2.x] added loginEndPointWithPath#1374

Merged
RyanL1997 merged 3 commits into2.xfrom
backport/backport-1358-to-2.x
Mar 21, 2023
Merged

[Backport 2.x] added loginEndPointWithPath#1374
RyanL1997 merged 3 commits into2.xfrom
backport/backport-1358-to-2.x

Conversation

@opensearch-trigger-bot
Copy link
Contributor

Backport 87e64cf from #1358

* added loginEndPointWithPath
Signed-off-by: Mattijs Vanhaverbeke <mattijs-v@live.be>
(cherry picked from commit 87e64cf)
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team March 7, 2023 20:56
@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2023

Codecov Report

Merging #1374 (f8dd791) into 2.x (51483d4) will increase coverage by 0.01%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##              2.x    #1374      +/-   ##
==========================================
+ Coverage   71.78%   71.79%   +0.01%     
==========================================
  Files          88       88              
  Lines        2027     2028       +1     
  Branches      269      269              
==========================================
+ Hits         1455     1456       +1     
  Misses        509      509              
  Partials       63       63              
Impacted Files Coverage Δ
public/apps/login/login-page.tsx 73.80% <100.00%> (+0.31%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@peternied
Copy link
Member

Looks like this job is consistently failing (4 attempts to retry)
image

@RyanL1997 Can you create an issue and dig-in on these failures?

@RyanL1997
Copy link
Collaborator

RyanL1997 commented Mar 14, 2023

Looks like this job is consistently failing (4 attempts to retry) image

@RyanL1997 Can you create an issue and dig-in on these failures?

Reference to Chang's comment: #1361 (comment). Since we have rebased this PR with this change #1361. And this change has been merged into security repo. I think the test will pass, if we get the new build of 2.x security plugin with this change.

@RyanL1997
Copy link
Collaborator

The current snapshot is pointing to 2.6.0 which didn't have this change included, and I'm incrementing the version of this repo to 2.7.0, so that the CI can point to the correct snapshot. This PR should be unblocked after this one ( #1382) gets merged.

@RyanL1997 RyanL1997 merged commit d1d9ff8 into 2.x Mar 21, 2023
@github-actions github-actions bot deleted the backport/backport-1358-to-2.x branch March 21, 2023 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants