Fix plugin configuration path#1304
Merged
peternied merged 2 commits intoopensearch-project:mainfrom Jan 24, 2023
Merged
Conversation
smortex
force-pushed
the
fix-plugin-config-path
branch
from
42cae27 to
d4c9b84
Compare
cwperks
previously approved these changes
Jan 19, 2023
Member
|
Thank you for the contribution @smortex! The change looks good to me. |
peternied
requested changes
Jan 19, 2023
Member
peternied
left a comment
peternied
left a comment
There was a problem hiding this comment.
Thanks for the contribution, we are really close to merging this pull request. It looks like the continuous integrations checks are failing for this change, please take a look.
public/apps/configuration/panels/auth-view/instruction-view.tsx
Outdated
Show resolved
Hide resolved
The dashboard has references to an old path that does not exist anymore: `plugins/opensearch-security/securityconfig/config.yml`. It was replaced by `config/opensearch-security/config.yml` in this commit: opensearch-project/security@b44d7ea Fix the last occurences of `plugins/opensearch-security/securityconfig`. Signed-off-by: Romain Tartière <romain@blogreen.org>
smortex
force-pushed
the
fix-plugin-config-path
branch
from
d4c9b84 to
f07385e
Compare
Contributor
Author
|
I amended the commit with the needed change and force pushed to update the PR. CI still needs to be approved, thanks! |
Collaborator
Thanks for the recommit, and I just re-run the CI. |
Codecov Report
@@ Coverage Diff @@
## main #1304 +/- ##
=======================================
Coverage 71.78% 71.78%
=======================================
Files 88 88
Lines 2027 2027
Branches 274 274
=======================================
Hits 1455 1455
Misses 509 509
Partials 63 63
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
RyanL1997
approved these changes
Jan 20, 2023
cwperks
approved these changes
Jan 20, 2023
DarshitChanpura
approved these changes
Jan 20, 2023
stephen-crawford
approved these changes
Jan 23, 2023
Contributor
stephen-crawford
left a comment
stephen-crawford
left a comment
There was a problem hiding this comment.
Looks good to me!
Member
|
@peternied Can you resolve your requested change? I get a |
peternied
approved these changes
Jan 24, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 21, 2023
The dashboard has references to an old path that does not exist anymore: `plugins/opensearch-security/securityconfig/config.yml`. It was replaced by `config/opensearch-security/config.yml` in this commit: opensearch-project/security@b44d7ea Fix the last occurences of `plugins/opensearch-security/securityconfig`. Signed-off-by: Romain Tartière <romain@blogreen.org> Co-authored-by: Stephen Crawford <65832608+scrawfor99@users.noreply.github.com> (cherry picked from commit 82c27c7)
cwperks
added a commit
that referenced
this pull request
Feb 21, 2023
The dashboard has references to an old path that does not exist anymore: `plugins/opensearch-security/securityconfig/config.yml`. It was replaced by `config/opensearch-security/config.yml` in this commit: opensearch-project/security@b44d7ea Fix the last occurences of `plugins/opensearch-security/securityconfig`. Signed-off-by: Romain Tartière <romain@blogreen.org> Co-authored-by: Stephen Crawford <65832608+scrawfor99@users.noreply.github.com> (cherry picked from commit 82c27c7) Co-authored-by: Romain Tartière <romain@blogreen.org> Co-authored-by: Craig Perkins <cwperx@amazon.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dashboard has references to an old path that does not exist anymore:
plugins/opensearch-security/securityconfig/config.yml. It wasreplaced by
config/opensearch-security/config.ymlin this commit:opensearch-project/security@b44d7ea
Fix the last occurences of
plugins/opensearch-security/securityconfig.