[Backport 1.3] Preserve URL Hash for SAML based login#1219
[Backport 1.3] Preserve URL Hash for SAML based login#1219opensearch-trigger-bot[bot] wants to merge 1 commit into1.3from
Conversation
* Preserve URL HASH after user logs via SAML IDP Co-authored-by: Darshit Chanpura <35282393+DarshitChanpura@users.noreply.github.com> (cherry picked from commit a9d10d8)
Codecov Report
@@ Coverage Diff @@
## 1.3 #1219 +/- ##
=======================================
Coverage 74.11% 74.11%
=======================================
Files 86 86
Lines 1862 1862
Branches 239 239
=======================================
Hits 1380 1380
Misses 426 426
Partials 56 56 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
@scrawfor99 There were tests added in a separate PR for this SAML change. That PR would also need to be backported and included here: #1088 Looks like we also need to perform a version increment on the 1.3 branch to match core. |
|
What does the version increment on 1.3 entail? I am not sure I know what should be incremented since I assume it should be against core's own 1.3 branch. I will add the tests to make sure they get included. |
|
@scrawfor99 See a previous increment PR here: #1113 |
|
I think this should contain all the things you want incremented and backported: #1220 Let me know what needs to be done from there. I was not sure the best way to combine the two backports of the tests and these changes so just manually added the code together into one. |
|
@scrawfor99 Lets close this PR out in favor of the new one you created with the tests included |
Backport a9d10d8 from #1039