Add retry and enable UTs for Windows#1215
Merged
peternied merged 1 commit intoopensearch-project:mainfrom Nov 15, 2022
Merged
Conversation
Added a retry around the the bootstrap that previously failed due to network issues. Ran the new version of this workflow 100x on linux and 100x on windows, both passed at 100% [1]. Without the retry during a run of 100 times iterations [2], the windows test failed once during the bootstrap. If we see future issues, we could attempt to add retries to them following this same pattern. [1] https://github.com/peternied/security-dashboards-plugin/actions/runs/3449518073 [2] https://github.com/peternied/security-dashboards-plugin/actions/runs/3449040181 - Resolves opensearch-project#1211 - Resolves opensearch-project#1195 Signed-off-by: Peter Nied <petern@amazon.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1215 +/- ##
=======================================
Coverage 71.78% 71.78%
=======================================
Files 88 88
Lines 2027 2027
Branches 269 269
=======================================
Hits 1455 1455
Misses 509 509
Partials 63 63 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cwperks
approved these changes
Nov 14, 2022
RyanL1997
approved these changes
Nov 15, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 16, 2022
Added a retry around the the bootstrap that previously failed due to network issues. Ran the new version of this workflow 100 iterations on linux and windows, both passed at 100% [1]. Without the retry during a run of 100 iterations [2], the windows test failed once during the bootstrap. If we see future issues, we could attempt to add retries to them following this same pattern. [1] https://github.com/peternied/security-dashboards-plugin/actions/runs/3449518073 [2] https://github.com/peternied/security-dashboards-plugin/actions/runs/3449040181 Signed-off-by: Peter Nied <petern@amazon.com> (cherry picked from commit 3abb707)
cwperks
pushed a commit
that referenced
this pull request
Nov 16, 2022
Added a retry around the the bootstrap that previously failed due to network issues. Ran the new version of this workflow 100 iterations on linux and windows, both passed at 100% [1]. Without the retry during a run of 100 iterations [2], the windows test failed once during the bootstrap. If we see future issues, we could attempt to add retries to them following this same pattern. [1] https://github.com/peternied/security-dashboards-plugin/actions/runs/3449518073 [2] https://github.com/peternied/security-dashboards-plugin/actions/runs/3449040181 Signed-off-by: Peter Nied <petern@amazon.com> (cherry picked from commit 3abb707) Co-authored-by: Peter Nied <petern@amazon.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added a retry around the the bootstrap that previously failed due to network issues. Ran the new version of this workflow 100 iterations on linux and windows, both passed at 100% [1].
Without the retry during a run of 100 iterations [2], the windows test failed once during the bootstrap. If we see future issues, we could attempt to add retries to them following this same pattern.
[1] https://github.com/peternied/security-dashboards-plugin/actions/runs/3449518073
[2] https://github.com/peternied/security-dashboards-plugin/actions/runs/3449040181
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.