Skip to content

[Feature Branch] Resolve review comments#1155

Merged
cliu123 merged 21 commits intoopensearch-project:main_aggregation_viewfrom
cliu123:main_aggregation_view
Oct 25, 2022
Merged

[Feature Branch] Resolve review comments#1155
cliu123 merged 21 commits intoopensearch-project:main_aggregation_viewfrom
cliu123:main_aggregation_view

Conversation

@cliu123
Copy link
Member

@cliu123 cliu123 commented Oct 25, 2022

Description

[Describe what this change achieves]

Category

[Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation]

Why these changes are required?

What is the old behavior before changes and new behavior after changes?

Issues Resolved

[List any issues this PR will resolve (Is this a backport? If so, please add backport PR # and/or commits #)]

Testing

Successful builds:
Cypress tests: https://github.com/opensearch-project/security-dashboards-plugin/actions/runs/3322826251/jobs/5492386635
Integration tests: https://github.com/opensearch-project/security-dashboards-plugin/actions/runs/3322826241/jobs/5492705091
Unit Tests: https://github.com/opensearch-project/security-dashboards-plugin/actions/runs/3322826238/jobs/5492386772

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Chang Liu <lc12251109@gmail.com>
Signed-off-by: Chang Liu <lc12251109@gmail.com>
Signed-off-by: Chang Liu <lc12251109@gmail.com>
Signed-off-by: Chang Liu <lc12251109@gmail.com>
Signed-off-by: Chang Liu <lc12251109@gmail.com>
Signed-off-by: Chang Liu <lc12251109@gmail.com>
Signed-off-by: Chang Liu <lc12251109@gmail.com>
Signed-off-by: Chang Liu <lc12251109@gmail.com>
Signed-off-by: Chang Liu <lc12251109@gmail.com>
Signed-off-by: Chang Liu <lc12251109@gmail.com>
Signed-off-by: Chang Liu <lc12251109@gmail.com>
Signed-off-by: Chang Liu <lc12251109@gmail.com>
Signed-off-by: Chang Liu <lc12251109@gmail.com>
Signed-off-by: Chang Liu <lc12251109@gmail.com>
Signed-off-by: Chang Liu <lc12251109@gmail.com>
Signed-off-by: Chang Liu <lc12251109@gmail.com>
Signed-off-by: Chang Liu <lc12251109@gmail.com>
Signed-off-by: Chang Liu <lc12251109@gmail.com>
@cliu123 cliu123 requested a review from a team October 25, 2022 06:51
Signed-off-by: Chang Liu <lc12251109@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #1155 (9b54a52) into main_aggregation_view (52bb373) will decrease coverage by 0.29%.
The diff coverage is n/a.

❗ Current head 9b54a52 differs from pull request most recent head ee16531. Consider uploading reports for the commit ee16531 to get more accurate results

@@                    Coverage Diff                    @@
##           main_aggregation_view    #1155      +/-   ##
=========================================================
- Coverage                  74.28%   73.98%   -0.30%     
=========================================================
  Files                         86       86              
  Lines                       1886     1899      +13     
  Branches                     249      251       +2     
=========================================================
+ Hits                        1401     1405       +4     
- Misses                       428      437       +9     
  Partials                      57       57              
Impacted Files Coverage Δ
...hboards-plugin/public/apps/account/account-app.tsx 56.66% <0.00%> (-5.41%) ⬇️
...n/public/apps/configuration/utils/tenant-utils.tsx 69.23% <0.00%> (-5.02%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cliu123 cliu123 force-pushed the main_aggregation_view branch from ee16531 to 8b5f97d Compare October 25, 2022 18:38
@cliu123 cliu123 merged commit 2a827da into opensearch-project:main_aggregation_view Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants