[Feature Branch] Resolve review comments#1152
Merged
cliu123 merged 5 commits intoopensearch-project:main_aggregation_viewfrom Oct 23, 2022
Merged
[Feature Branch] Resolve review comments#1152cliu123 merged 5 commits intoopensearch-project:main_aggregation_viewfrom
cliu123 merged 5 commits intoopensearch-project:main_aggregation_viewfrom
Conversation
Signed-off-by: Chang Liu <lc12251109@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main_aggregation_view #1152 +/- ##
=========================================================
- Coverage 74.29% 74.28% -0.02%
=========================================================
Files 86 86
Lines 1879 1886 +7
Branches 246 249 +3
=========================================================
+ Hits 1396 1401 +5
- Misses 426 428 +2
Partials 57 57
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Chang Liu <lc12251109@gmail.com>
cliu123
force-pushed
the
main_aggregation_view
branch
2 times, most recently
from
85d6333 to
a88b998
Compare
Signed-off-by: Chang Liu <lc12251109@gmail.com>
cliu123
force-pushed
the
main_aggregation_view
branch
from
a88b998 to
9dedb4f
Compare
Signed-off-by: Chang Liu <lc12251109@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Chang Liu lc12251109@gmail.com
Description
[Describe what this change achieves]
Category
[Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation]
Why these changes are required?
What is the old behavior before changes and new behavior after changes?
Issues Resolved
[List any issues this PR will resolve (Is this a backport? If so, please add backport PR # and/or commits #)]
Testing
[Please provide details of testing done: unit testing, integration testing and manual testing]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.