Fix the UI user flow of selecting custom teanant on tenant switch panel

[RyanL1997]

Signed-off-by: Ryan Liang jiallian@amazon.com

Description

• Add description into the custom tenant selecting dropdown list, and disable the button when there is no valid selection for custom tenant.
• Update the unit test.

Category

Bug fix

Issues Resolved

• Resolved No warning or error message displays when no tenant is chosen under choose from custom option #819

Testing

Check List

• New functionality includes testing
• New functionality has been documented
• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.43%. Comparing base (bf5691f) to head (f27aafc).
Report is 208 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1112      +/-   ##
==========================================
+ Coverage   74.39%   74.43%   +0.04%     
==========================================
  Files          86       86              
  Lines        1871     1874       +3     
  Branches      241      244       +3     
==========================================
+ Hits         1392     1395       +3     
  Misses        424      424              
  Partials       55       55              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[RyanL1997]

Hi @shanilpa, thank you for the instruction: #819 (comment). The fix has been implemented.

[peternied]

Looks fine to me, might need some work to get the CI working

[RyanL1997]

Looks fine to me, might need some work to get the CI working

Hi @peternied, thanks for the review. I just fixed the tests.

[DarshitChanpura]

Thanks @RyanL1997 !

[peternied]

Can we move the logic into a local variable it is not duplicated it on both lines?

[RyanL1997]

Thanks for the review! I just made an update on this.

[cwperks]

I see we've now added a condition on fill here. I just want to confirm if this is intended behavior.

fill is related to whether the bg of the button is filled in or transparent. See https://eui.elastic.co/pr_3350/#/navigation/button

[RyanL1997]

Hi @cwperks, thanks for the review! I talked to @shanilpa, and he suggested me to change the disabled button to the ghosted disabled without the fill option, because that's the pattern we are moving forward with. That's why I added the condition to the fill option.

[shanilpa]

@RyanL1997 that's correct. We're looking to reduce some of the visual clutter by making use of the ghosted disabled state. Thanks for the review @cwperks.

[cwperks]

@RyanL1997 Looks like this branch needs to be re-based, please re-base with the latest changes in main. Should this change be backported to 2.x?

[RyanL1997]

@RyanL1997 Looks like this branch needs to be re-based, please re-base with the latest changes in main. Should this change be backported to 2.x?

@cwperks Thanks! I just re-pushed with the rebased repo. Yeah, I think we do need to add the 2.x backporting label.