[Backport 2.x] fix-expiration-of-token-from-actual-idtoken#1091
Merged
[Backport 2.x] fix-expiration-of-token-from-actual-idtoken#1091
Conversation
Use expiration of tokens from the id token The like oidc token response from Gitlab expiresIn property is not the actual expiration of the idToken. idToken expires before the access_token does. This fix allows the security plugin used when integrating with Gitlab Signed-off-by: Vasile Negru <vasile@eosfintek.com> (cherry picked from commit 057cbe4)
Codecov Report
@@ Coverage Diff @@
## 2.x #1091 +/- ##
=======================================
Coverage 72.27% 72.27%
=======================================
Files 87 87
Lines 1915 1915
Branches 244 244
=======================================
Hits 1384 1384
Misses 478 478
Partials 53 53 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
peternied
approved these changes
Aug 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport 057cbe4 from #1040