Add the feature of showing useful error message during CI#1083
Add the feature of showing useful error message during CI#1083cliu123 merged 1 commit intoopensearch-project:mainfrom
Conversation
045ea0b to
6d689bc
Compare
Codecov Report
@@ Coverage Diff @@
## main #1083 +/- ##
=======================================
Coverage 72.27% 72.27%
=======================================
Files 87 87
Lines 1915 1915
Branches 244 244
=======================================
Hits 1384 1384
Misses 478 478
Partials 53 53 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Is it possible to create variables in the Github actions files? We use the version in a number of places and it would be nice to define it once.
There was a problem hiding this comment.
Hi @cwperks. Thanks for the reply. I think we can only set up the environment variables in the Github actions files. I can definitely try to set it up in the environment variable to see if it works.
There was a problem hiding this comment.
This would fail the integration-test workflow, what would you think about creating a separate workflow called something like prerequisites that could have a task named "Verify there is matching build of security plugin"
There was a problem hiding this comment.
Hi @peternied. Thanks for the reply! The reason I set to check it up here because if this one fails, the next test of Download OpenSearch Security Plugin will also be failed and break the integration-test. I was planning to use this test only as the prerequisite for checking the test of Download OpenSearch Security Plugin. Sorry for the confusions anyways. Please correct me if I miss some of the steps.
There was a problem hiding this comment.
I think I get it now! Ya I will create a new work flow with a better name for running this separately! Thanks @peternied!
5a346cf to
cf9334e
Compare
63d3b75 to
7a7531e
Compare
|
He guys, I have made the update of this PR:
|
|
@RyanL1997 Would you please add the new behavior in the PR description? |
7a7531e to
ace1a7b
Compare
ace1a7b to
98cfda1
Compare
There was a problem hiding this comment.
The name of this should reflect what the check is performing. How does "Check for the existence of the OpenSearch Security Plugin artifact" sound?
There was a problem hiding this comment.
Sure, I have updated the commit and also changed the PR description with that. Thx for the review @cwperks!
98cfda1 to
3c01353
Compare
There was a problem hiding this comment.
Similar to above: maybe "Run prerequisite checks"?
There was a problem hiding this comment.
Thanks! I have changed the name for both test's name and the sub tests' name. Please review it.
3c01353 to
cac0c5e
Compare
…sion variable Signed-off-by: Ryan Liang <jiallian@amazon.com>
cac0c5e to
b62d5cd
Compare


Signed-off-by: Ryan Liang jiallian@amazon.com
Description
Create a separate workflow and implemented environment variable of version to check for the existence of the OpenSearch Security Plugin artifact
Issues Resolved
Testing
CI test case#1 with "403 Forbidden" responseCI test case#2 with "404 Not Found" responseCreated a new workflow for "Verify there is matching build of security plugin" by running
prerequisites-testCheck List
New functionality includes testingNew functionality has been documentedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.