Skip to content

[Backport 1.0] Backport #1024 tenant resolver#1048

Closed
opensearch-trigger-bot[bot] wants to merge 1 commit into1.0from
backport/backport-1043-to-1.0
Closed

[Backport 1.0] Backport #1024 tenant resolver#1048
opensearch-trigger-bot[bot] wants to merge 1 commit into1.0from
backport/backport-1043-to-1.0

Conversation

@opensearch-trigger-bot
Copy link
Contributor

Backport bbe43c1 from #1043

Signed-off-by: Rutuja Surve <rutuja@amazon.com>
(cherry picked from commit bbe43c1)
@cliu123
Copy link
Member

cliu123 commented Aug 9, 2022

@rutuja-amazon Bootstrap OpenSearch Dashboards failed. Would you please take a look? Same error happens in other 2 backport PRs.

ERROR [single_version_dependencies] Multiple version ranges for the same dependency
      were found declared across different package.json files. Please consolidate
      those to match across all package.json files. Different versions for the
      same dependency is not supported.

      If you have questions about this please reach out to the operations team.

      The conflicting dependencies are:

        @testing-library/react-hooks
          ^7.0.2 => opensearch-dashboards
          ^3.4.1 => opensearch-security-dashboards
        @hapi/wreck
          ^17.1.0 => opensearch-dashboards
          ^15.0.2 => opensearch-security-dashboards

@rutuja-amazon
Copy link

rutuja-amazon commented Aug 10, 2022

@cliu123 not sure why this commit has raised dependency related issues for ^7.0.2 => opensearch-dashboards and
^3.4.1 => opensearch-security-dashboards. This did not happen for manually raised PR for a later version 1.3. Could you please recommend if we could close the autobot triggered PRs and try to manually raise again? Could you please help with the right dependency versions here?

@peternied
Copy link
Member

After much consideration and discussion the branch that is being targeted 1.0 is unsupported only 1.3 is currently maintained, and this code is being used and maintained by a private fork. Rather than gate changes to a fork, it makes more sense for that repository to diverge in the areas its supporting but this repository are not supporting. This avoids having to wait on the security maintainers to review / approve / merge changes - doubly so when these changes cannot be validated by the CI systems in GitHub associated with them.

I am closing out this pull request and the other related pull requests, separately we will consider how we want to address these branches that are no longer supported, in other OpenSearch Project components the ODFE versions of the codebases were archived whereas this one was copied with all its issues.

@peternied peternied closed this Aug 12, 2022
@peternied peternied deleted the backport/backport-1043-to-1.0 branch November 30, 2022 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants