Revert "Revert "Replace _opendistro route with _plugins""#1038
Closed
DarshitChanpura wants to merge 1 commit intomainfrom
Closed
Revert "Revert "Replace _opendistro route with _plugins""#1038DarshitChanpura wants to merge 1 commit intomainfrom
DarshitChanpura wants to merge 1 commit intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1038 +/- ##
=======================================
Coverage 72.27% 72.27%
=======================================
Files 87 87
Lines 1915 1915
Branches 244 244
=======================================
Hits 1384 1384
Misses 478 478
Partials 53 53 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
@DarshitChanpura Is this PR ready? |
Member
Author
The PR is ready but we have to wait until opensearch-project/security#1936 is merged. |
3 tasks
Member
|
@DarshitChanpura Lets create a fresh PR with the change we would like to see, this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR brings in the original changes that were reverted due to broken SAML authentication issue.
NOTE: This PR shouldn't be merged until opensearch-project/security#1936 is merged
Related Issues:
#1031
opensearch-project/security#1941