Skip to content

Revert "Revert "Replace _opendistro route with _plugins""#1038

Closed
DarshitChanpura wants to merge 1 commit intomainfrom
revert-1035-revert-895-fix-routes
Closed

Revert "Revert "Replace _opendistro route with _plugins""#1038
DarshitChanpura wants to merge 1 commit intomainfrom
revert-1035-revert-895-fix-routes

Conversation

@DarshitChanpura
Copy link
Member

This PR brings in the original changes that were reverted due to broken SAML authentication issue.

NOTE: This PR shouldn't be merged until opensearch-project/security#1936 is merged

Related Issues:
#1031
opensearch-project/security#1941

@DarshitChanpura DarshitChanpura added backport 2.x backport to 2.x branch backport 2.1 backport 2.1 branch labels Jul 20, 2022
@DarshitChanpura DarshitChanpura requested a review from a team July 20, 2022 17:17
@DarshitChanpura DarshitChanpura marked this pull request as draft July 20, 2022 17:18
@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2022

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.27%. Comparing base (cc5b763) to head (a506d7a).
⚠️ Report is 290 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1038   +/-   ##
=======================================
  Coverage   72.27%   72.27%           
=======================================
  Files          87       87           
  Lines        1915     1915           
  Branches      244      244           
=======================================
  Hits         1384     1384           
  Misses        478      478           
  Partials       53       53           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cliu123
Copy link
Member

cliu123 commented Jul 26, 2022

@DarshitChanpura Is this PR ready?

@DarshitChanpura
Copy link
Member Author

@DarshitChanpura Is this PR ready?

The PR is ready but we have to wait until opensearch-project/security#1936 is merged.

@peternied
Copy link
Member

@DarshitChanpura Lets create a fresh PR with the change we would like to see, this revert revert is a little confounding

@peternied peternied closed this Aug 9, 2022
@peternied peternied deleted the revert-1035-revert-895-fix-routes branch November 30, 2022 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 2.x backport to 2.x branch backport 2.1 backport 2.1 branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants