Preserve url hash for saml based authentication#1001
Closed
devardee wants to merge 1 commit intoopensearch-project:mainfrom
devardee:main
Closed
Preserve url hash for saml based authentication#1001devardee wants to merge 1 commit intoopensearch-project:mainfrom devardee:main
devardee wants to merge 1 commit intoopensearch-project:mainfrom
devardee:main
Conversation
peternied
requested changes
May 26, 2022
Member
peternied
left a comment
peternied
left a comment
There was a problem hiding this comment.
Thank you for the contribution, this will greatly improve the post sign-in experience with SAML auth.
There are a couple of gaps before this change can be merged. Functional test cases for the new routes and the end to end workflow must be added.
All commits are required to be signed off per the DCO more details.
Let us know if you have questions about how to accomplish these outstanding items,
Member
|
@devardee Have you got chance to follow up on this PR at all? We would love to have another review when the comments are resolved. Thanks! |
Member
|
Closing the PR due to inactivity for now. Please feel free to re-open if needed. |
2 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Preserves the url hash after saml handshake.
Category
Enhancement
Why these changes are required?
For better user experience. refer to #543 and #831.
What is the old behavior before changes and new behavior after changes?
refer to #543 and #831
Issues Resolved
#831 #543
Testing
manual tested.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.