Include AdditionalCodecs argument to allow additional Codec registration - #1636
Merged
Merged
Conversation
Signed-off-by: Andriy Redko <drreta@gmail.com>
reta
requested review from
AWSHurneyt,
amsiglan,
eirsep,
engechas,
getsaurabh02,
goyamegh,
jowg-amazon,
lezzago,
praveensameneni,
riysaxen-amzn,
sbcd90 and
toepkerd
as code owners
January 29, 2026 18:39
reta
commented
Jan 29, 2026
|
|
||
| public CorrelationCodecService(CodecServiceConfig codecServiceConfig, IndexSettings indexSettings) { | ||
| super(codecServiceConfig.getMapperService(), indexSettings, codecServiceConfig.getLogger()); | ||
| super(codecServiceConfig.getMapperService(), indexSettings, codecServiceConfig.getLogger(), codecServiceConfig.getAdditionalCodecs()); |
Contributor
Author
There was a problem hiding this comment.
The change looks breaking but this is experimental API at the moment
Contributor
Author
|
Needs backport to 3.5 label please (cannot create one) |
cwperks
approved these changes
Jan 29, 2026
cwperks
pushed a commit
that referenced
this pull request
Jan 29, 2026
…ion (#1636) (#1637) (cherry picked from commit 179cb1a) Signed-off-by: Andriy Redko <drreta@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Include AdditionalCodecs argument to allow additional Codec registration
Related Issues
Followup on opensearch-project/OpenSearch#20411
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.