-
Notifications
You must be signed in to change notification settings - Fork 25
Upgrade gradle to 8.14 and JDK 23->24 #188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade gradle to 8.14 and JDK 23->24 #188
Conversation
Signed-off-by: Martin Gaievski <[email protected]>
62619b3 to
ee38049
Compare
Signed-off-by: Martin Gaievski <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| permission java.lang.RuntimePermission "accessDeclaredMembers"; | ||
| permission java.lang.reflect.ReflectPermission "suppressAccessChecks"; | ||
| permission java.lang.RuntimePermission "setContextClassLoader"; | ||
| permission java.net.NetPermission "accessUnixDomainSocket"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@martin-gaievski can we try removing this from the PR? This permission is already granted by the test-framework. See https://github.com/opensearch-project/OpenSearch/blob/main/server/src/main/resources/org/opensearch/bootstrap/test-framework.policy#L188
Last night, the issue was that opensearch-project/OpenSearch#18764 was still unmerged. Now that its merged the tests are passing and this entry shouldn't be necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reverted permissions in 5ec0409, let's wait and see for CI behaves
Signed-off-by: Martin Gaievski <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #188 +/- ##
===========================
===========================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
Updated gradle and java version to 24.
Request for all plugins from infra team, prereq for 3.2 release. Follow path of other plugins (e.g. opensearch-project/k-NN#2792)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.