Skip to content

Conversation

@martin-gaievski
Copy link
Member

@martin-gaievski martin-gaievski commented Jul 15, 2025

Description

Updated gradle and java version to 24.

Request for all plugins from infra team, prereq for 3.2 release. Follow path of other plugins (e.g. opensearch-project/k-NN#2792)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@martin-gaievski martin-gaievski force-pushed the bump_gradle_and_jdk_versions branch from 62619b3 to ee38049 Compare July 15, 2025 18:36
@martin-gaievski martin-gaievski marked this pull request as ready for review July 16, 2025 16:30
Copy link
Collaborator

@fen-qin fen-qin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

permission java.lang.RuntimePermission "accessDeclaredMembers";
permission java.lang.reflect.ReflectPermission "suppressAccessChecks";
permission java.lang.RuntimePermission "setContextClassLoader";
permission java.net.NetPermission "accessUnixDomainSocket";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@martin-gaievski can we try removing this from the PR? This permission is already granted by the test-framework. See https://github.com/opensearch-project/OpenSearch/blob/main/server/src/main/resources/org/opensearch/bootstrap/test-framework.policy#L188

Last night, the issue was that opensearch-project/OpenSearch#18764 was still unmerged. Now that its merged the tests are passing and this entry shouldn't be necessary.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reverted permissions in 5ec0409, let's wait and see for CI behaves

Signed-off-by: Martin Gaievski <[email protected]>
@heemin32 heemin32 merged commit 498162d into opensearch-project:main Jul 16, 2025
20 of 28 checks passed
@codecov
Copy link

codecov bot commented Jul 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (9e6196b) to head (5ec0409).
Report is 4 commits behind head on main.

Additional details and impacted files
@@     Coverage Diff     @@
##   main   #188   +/-   ##
===========================
===========================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants