Bump to 2.0 alpha1 and gradle 7#325
Merged
davidcui1225 merged 17 commits intoopensearch-project:mainfrom Apr 4, 2022
davidcui1225:gradle-2-bump
Merged
Bump to 2.0 alpha1 and gradle 7#325davidcui1225 merged 17 commits intoopensearch-project:mainfrom davidcui1225:gradle-2-bump
davidcui1225 merged 17 commits intoopensearch-project:mainfrom
davidcui1225:gradle-2-bump
Conversation
Signed-off-by: David Cui <davidcui@amazon.com>
Signed-off-by: David Cui <davidcui@amazon.com>
Signed-off-by: David Cui <davidcui@amazon.com>
Signed-off-by: David Cui <davidcui@amazon.com>
Signed-off-by: David Cui <davidcui@amazon.com>
Signed-off-by: David Cui <davidcui@amazon.com>
Signed-off-by: David Cui <davidcui@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #325 +/- ##
============================================
+ Coverage 72.64% 74.23% +1.58%
- Complexity 373 383 +10
============================================
Files 94 94
Lines 3963 3966 +3
Branches 644 639 -5
============================================
+ Hits 2879 2944 +65
+ Misses 909 888 -21
+ Partials 175 134 -41
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: David Cui <davidcui@amazon.com>
Signed-off-by: David Cui <davidcui@amazon.com>
Signed-off-by: David Cui <davidcui@amazon.com>
Signed-off-by: David Cui <davidcui@amazon.com>
Signed-off-by: David Cui <davidcui@amazon.com>
Signed-off-by: David Cui <davidcui@amazon.com>
kavithacm
reviewed
Apr 1, 2022
Collaborator
kavithacm
left a comment
kavithacm
left a comment
There was a problem hiding this comment.
build seems to be failing, can you upgrade the following
enzyme-adapter-react-16
^1.15.5 => opensearch-dashboards
^1.15.2 => reports-dashboards
Signed-off-by: David Cui <davidcui@amazon.com>
vamsimanohar
reviewed
Apr 1, 2022
| opensearch_version = System.getProperty("opensearch.version", "2.0.0-alpha1-SNAPSHOT") | ||
| // 1.0.0 -> 1.0.0.0, and 1.0.0-SNAPSHOT -> 1.0.0.0-SNAPSHOT | ||
| opensearch_build = opensearch_version.replaceAll(/(\.\d)([^\d]*)$/, '$1.0$2') | ||
| opensearch_build = opensearch_version.replaceAll(/(\.\d(?!\.\d))/, '$1.0') |
Member
There was a problem hiding this comment.
opensearch_build = opensearch_version.replaceAll(/([\d.]*.\d+(?!.\d))/, '$1.0')
Please replace this to handle multiple digits.
Contributor
Author
There was a problem hiding this comment.
Was common-utils 2.0.0 alpha1 deprecated? backend build is failing immediately because it can't resolve the reference
Signed-off-by: David Cui <davidcui@amazon.com>
joshuali925
previously approved these changes
Apr 2, 2022
6 tasks
Signed-off-by: David Cui <davidcui@amazon.com>
Signed-off-by: David Cui <davidcui@amazon.com>
joshuali925
approved these changes
Apr 4, 2022
This was referenced Apr 12, 2022
Closed
Closed
kavilla
pushed a commit
to kavilla/dashboards-reports
that referenced
this pull request
Jul 12, 2023
Bumping gradle 7, reporting to 2.0 and removed mapping types Signed-off-by: David Cui <davidcui@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: David Cui davidcui@amazon.com
Description
CreateIndexRequestIssues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.