Fix AdmissionControl class loading issue in Netty/PA communication #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gashutos <[email protected]>
linuxpi
previously approved these changes
Mar 20, 2023
khushbr
reviewed
Mar 22, 2023
...ain/java/org/opensearch/performanceanalyzer/collectors/AdmissionControlMetricsCollector.java
Outdated
Show resolved
Hide resolved
...ain/java/org/opensearch/performanceanalyzer/collectors/AdmissionControlMetricsCollector.java
Outdated
Show resolved
Hide resolved
...ain/java/org/opensearch/performanceanalyzer/collectors/AdmissionControlMetricsCollector.java
Outdated
Show resolved
Hide resolved
Signed-off-by: gashutos <[email protected]>
khushbr
previously approved these changes
Mar 23, 2023
linuxpi
previously approved these changes
Mar 24, 2023
psychbot
reviewed
Mar 24, 2023
...ain/java/org/opensearch/performanceanalyzer/collectors/AdmissionControlMetricsCollector.java
Outdated
Show resolved
Hide resolved
|
Look for long term solution as mentioned in this issue. |
khushbr
approved these changes
Mar 24, 2023
sgup432
approved these changes
Mar 24, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 27, 2023
) * Fix AdmissionControl class loading issue in Netty/PA communication Signed-off-by: gashutos <[email protected]> * Addressing review comments Signed-off-by: gashutos <[email protected]> * Correcting type --------- Signed-off-by: gashutos <[email protected]> (cherry picked from commit 7c9a493)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 27, 2023
) * Fix AdmissionControl class loading issue in Netty/PA communication Signed-off-by: gashutos <[email protected]> * Addressing review comments Signed-off-by: gashutos <[email protected]> * Correcting type --------- Signed-off-by: gashutos <[email protected]> (cherry picked from commit 7c9a493)
2 tasks
khushbr
added a commit
to khushbr/performance-analyzer
that referenced
this pull request
Mar 30, 2023
…ation (opensearch-project#402)" This reverts commit 7c9a493.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is your feature request related to a problem? Please provide an existing Issue # , or describe.
PA AdmissionControl colector is taking dependency on AOS's AdmissionControl plugin to retrieve JVMMP & Request_Size
quota related metrics. PA uses reflection to retrieve static insances of AdmissionControllers.
Unit now it worked fine since, Jetty plugin was in /lib diretory and was getting loaded by same classloader. But now that AOS is moving to Netty, Netty is completely seperate plugin and no in /lib folder. Hence PA & Netty plugins shares different classloaders. However, there is a way we can still load AdmissionControl classes with parent ClassLoaders. PluginService when loads extended plugins, it passes parent classloader for all extended plugins. Ref
We will have to add a line, in opensearch-performance-analyzer plugin. So that PluginService passes AdmissionControl class loader to PA.
Describe alternatives you've considered
The cleanest way to implement this would be to provide an SPI from PA and AdmissionControl will use this SPI to implement controllers. In that way, PA will be
[ExtensiblePlugin](https://github.com/opensearch-project/OpenSearch/blob/main/server/src/main/java/org/opensearch/plugins/ExtensiblePlugin.java)and AdmissionControl plugin will extend PA plugin, I tried doing that and it resulted in lot of complications, like jar hell, dependencies version conflicts etc. Also this approach will clash with Jetty as now we will have tow different solutions for Netty/Jetty. We can still handle all those scenarios, but I would suggest to keep that task on our backlog (including making AdmissionControl plugin opensource).Additional context
Add any other context or screenshots about the feature request here.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.