Skip to content

Remove beta badge accent color #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BSFishy merged 1 commit into from
Dec 14, 2022
Merged

Remove beta badge accent color #99

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src-docs/src/views/badge/beta_badge.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import React from 'react';

import { OuiBetaBadge, OuiSpacer, OuiTitle } from '../../../../src/components';

const colors = ['hollow', 'accent', 'subdued'];
const colors = ['hollow', 'subdued'];

export default () => (
<div>
Expand Down
9 changes: 0 additions & 9 deletions src/components/badge/beta_badge/__snapshots__/beta_badge.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,6 @@ exports[`OuiBetaBadge is rendered 1`] = `
</span>
`;

exports[`OuiBetaBadge props color accent is rendered 1`] = `
<span
class="ouiBetaBadge ouiBetaBadge--accent"
title="Beta"
>
Beta
</span>
`;

exports[`OuiBetaBadge props color hollow is rendered 1`] = `
<span
class="ouiBetaBadge ouiBetaBadge--hollow"
Expand Down
10 changes: 0 additions & 10 deletions src/components/badge/beta_badge/_beta_badge.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,13 +86,3 @@
color: chooseLightOrDarkText($backgroundColor, $ouiColorGhost, $ouiColorInk);
}
}

.ouiBetaBadge--accent {
$backgroundColor: $ouiColorAccentText;
background: $backgroundColor;
color: chooseLightOrDarkText($backgroundColor, $ouiColorGhost, $ouiColorInk);

&.ouiBetaBadge-isClickable {
color: chooseLightOrDarkText($backgroundColor, $ouiColorGhost, $ouiColorInk);
}
}
3 changes: 1 addition & 2 deletions src/components/badge/beta_badge/beta_badge.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ import { OuiToolTip, ToolTipPositions } from '../../tool_tip';
import { OuiIcon, IconType } from '../../icon';

const colorToClassMap = {
accent: 'ouiBetaBadge--accent',
subdued: 'ouiBetaBadge--subdued',
hollow: 'ouiBetaBadge--hollow',
};
Expand Down Expand Up @@ -134,7 +133,7 @@ type BadgeProps = {
*/
title?: string;
/**
* Accepts accent, subdued and hollow.
* Accepts subdued and hollow.
*/
color?: BetaBadgeColor;
size?: BetaBadgeSize;
Expand Down