Skip to content

[Backport 1.x] Fix accessibility in doc site #857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joshuarrrr merged 1 commit into from
Jun 28, 2023
+3 −3
Merged

[Backport 1.x] Fix accessibility in doc site #857

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src-docs/src/assets/version-selector.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ const tpl = `
</style>
<a id="root" role="button" aria-labelledby="selected" aria-controls="dropdown" tabindex="0">
<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" role="img"
width="1em" height="1em" preserveAspectRatio="xMidYMid meet" viewBox="0 0 24 24">
width="1em" height="1em" preserveAspectRatio="xMidYMid meet" viewBox="0 0 24 24" aria-hidden="true">
<g fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round">
<path d="M6 9l6 6l6-6"/></g>
</svg>
Expand Down
2 changes: 1 addition & 1 deletion src-docs/src/views/suggest/global_filter_item.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ export const GlobalFilterItem = (props) => {
closeButtonProps={{
// Removing tab focus on close button because the same option can be optained through the context menu
// Also, we may want to add a `DEL` keyboard press functionality
tabIndex: '-1',
tabIndex: -1,
}}
{...rest}>
{prefix}
Expand Down
2 changes: 1 addition & 1 deletion src-docs/src/views/tool_tip/tool_tip.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ export default () => (
<p>
This tooltip appears on the bottom of this icon:{' '}
<OuiToolTip position="bottom" content="Here is some tooltip text">
<OuiIcon tabIndex="0" type="alert" />
<OuiIcon tabIndex="0" type="alert" aria-label="Alert" />
</OuiToolTip>
</p>
</OuiText>
Expand Down