Remove iconType and iconProps from OuiPageHeader#763
Merged
BSFishy merged 5 commits intoopensearch-project:mainfrom Jun 20, 2023
Merged
Remove iconType and iconProps from OuiPageHeader#763BSFishy merged 5 commits intoopensearch-project:mainfrom
iconType and iconProps from OuiPageHeader#763BSFishy merged 5 commits intoopensearch-project:mainfrom
Conversation
Signed-off-by: Sirazh Gabdullin <sirazh.gabdullin@nu.edu.kz>
Signed-off-by: Sirazh Gabdullin <sirazh.gabdullin@nu.edu.kz>
curq
requested review from
AMoo-Miki,
BSFishy,
KrooshalUX,
ashwin-pc,
bandinib-amzn,
joshuarrrr,
rednaksi91 and
seanneumann
as code owners
joshuarrrr
approved these changes
Jun 14, 2023
Member
|
@curq This just needs a conflict resolution, then we can merge. |
Signed-off-by: Sirazh Gabdullin <sirazh.gabdullin@nu.edu.kz>
Signed-off-by: Sirazh Gabdullin <sirazh.gabdullin@nu.edu.kz>
Contributor
Author
|
@joshuarrrr Done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removed
iconTypeandiconPropsas according to the #644 they will no longer be used/supported. It was first deprecated #759 and now will be removed.Issues Resolved
Solves #644
Check List
yarn lintyarn test-unitBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.