[CCI] Update tabbable dependency#650
Conversation
Co-authored-by: Sergey Myssak <sergey.myssak@gmail.com> Signed-off-by: Andrey Myssak <andreymyssak@gmail.com>
andreymyssak
force-pushed
the
594-update-tabble
branch
from
626b0b8 to
fba1a18
Compare
| const tabbableItems = tabbable(this.content, { | ||
| displayCheck: 'legacy-full', | ||
| }); |
There was a problem hiding this comment.
Why is this the only instance where options are added to the tabbable call? Is it special for some reason? Should the other calls to tabbable have it too?
There was a problem hiding this comment.
The rest of the cases do not cause problems with the tests and smoothly support the transition to the new version. In this file apparently a different case, after the upgrade the tests did not behave correctly, so I had to apply legacy-full.
There was a problem hiding this comment.
Let's open a follow-up issue to see if we can refactor and remove.
ashwin-pc
left a comment
ashwin-pc
left a comment
There was a problem hiding this comment.
Thanks for the change @andreymyssak! 🎉
| const tabbableItems = tabbable(this.content, { | ||
| displayCheck: 'legacy-full', | ||
| }); |
There was a problem hiding this comment.
Let's open a follow-up issue to see if we can refactor and remove.
(cherry picked from commit 419b57c) Signed-off-by: Andrey Myssak <andreymyssak@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Sergey Myssak <sergey.myssak@gmail.com>
4 participants
Description
Update tabbable dependency to 6.1.1
Issues Resolved
#594
Check List
yarn lintyarn test-unitBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.