Add a11y tests to workflow#641
Closed
BSFishy wants to merge 3 commits intoopensearch-project:mainfrom
Closed
Conversation
Signed-off-by: Matt Provost <provomat@amazon.com>
Signed-off-by: Matt Provost <provomat@amazon.com>
Contributor
Author
|
Accessibility errors will go away when #640 is merged |
joshuarrrr
approved these changes
Mar 30, 2023
ashwin-pc
approved these changes
Mar 30, 2023
ashwin-pc
requested changes
Mar 30, 2023
Member
ashwin-pc
left a comment
ashwin-pc
left a comment
There was a problem hiding this comment.
I ddint see the test failures before i approved them, can we also fix the a11y issues before adding them to the CI? No point adding something to the CI thats broken, making the CI useless.
joshuarrrr
requested review from
AMoo-Miki,
KrooshalUX,
SergeyMyssak,
andreymyssak,
bandinib-amzn,
rednaksi91 and
seanneumann
as code owners
Contributor
Author
|
Converting to draft until we get guidance on how to fix a11y issues |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Run accessibility tests when running the build and test workflow. The tests are and have been in the repository for a while, not sure why they weren't included in the workflow
Check List
yarn lintyarn test-unitBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.