Update docker for default admin creds update #114
Conversation
Signed-off-by: Derek Ho <[email protected]>
derek-ho
requested review from
Swiddis,
YANG-DB,
dai-chen,
joshuali925,
kavithacm,
mengweieric,
pjfitzgibbons,
ps48,
rupal-bq and
vamsimanohar
as code owners
|
@YANG-DB can you help me understand what other changes this repo needs? It doesn't seem to follow the branching strategy of main/2.x - so do we need to handle logic to determine whether to use the default admin password, or the env variable password in the ES_PASSWORD field? Any other places you see that would need changes? Thanks! |
|
@derek-ho please use the |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
|
Marking this as draft until variable OPENSEARCH_VERSION changes to >= 2.12.0. |
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
|
Done. @YANG-DB can you take another look? I also changed the image from staging to the actual released docker images, similar to the dashboards image (which is not using staging). |
docker-compose.yml
Outdated
| - cluster.initial_cluster_manager_nodes=opensearch | ||
| - bootstrap.memory_lock=true | ||
| - "OPENSEARCH_JAVA_OPTS=-Xms512m -Xmx512m" | ||
| - "OPENSEARCH_INITIAL_ADMIN_PASSWORD=myStrongPassword123!" |
There was a problem hiding this comment.
please use an env var for this field
Signed-off-by: Derek Ho <[email protected]>
docker-compose.yml
Outdated
|
|
||
| # OpenSearch store - engine | ||
| opensearch: | ||
| image: opensearchstaging/opensearch:${OPENSEARCH_VERSION} |
There was a problem hiding this comment.
Yes, it is a mismatch between OS backend and OSD image
|
@YANG-DB can you double check again and we can merge if everything looks good? |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
@YANG-DB @pjfitzgibbons @ps48 @kavithacm @joshuali925 @dai-chen @rupal-bq @mengweieric @vamsi-amazon @Swiddis Could we get this reviewed as we are targeting 2.12 for this change? |
|
@YANG-DB @pjfitzgibbons @ps48 @kavithacm @joshuali925 @dai-chen @rupal-bq @mengweieric @vamsi-amazon @Swiddis Still waiting for reviews. Could we get this reviewed as we are targeting 2.12 for this change? |
Signed-off-by: Derek Ho <[email protected]>
3 participants
Changes
Passes in an initial admin password via env variable, implemented in security plugin main and 2.x lines, for 2.12.0 release.
Merge Requirements
For new features contributions please make sure you have completed the following
essential items:
CHANGELOG.mdupdated to document new feature additionsMaintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.