Pre-validate duplicate columns in materialized view query#359
Merged
dai-chen merged 2 commits intoopensearch-project:mainfrom Jun 6, 2024
Merged
Conversation
Signed-off-by: Chen Dai <daichen@amazon.com>
dai-chen
requested review from
YANG-DB,
anirudha,
kaituo,
penghuo,
rupal-bq,
seankao-az and
vamsimanohar
as code owners
noCharger
approved these changes
Jun 6, 2024
| * MV query may be empty in the case of ALTER index statement. | ||
| */ | ||
| if (query.nonEmpty) { | ||
| val outputColNames = flint.spark.sql(query).schema.map(_.name) |
Collaborator
There was a problem hiding this comment.
just curious, this will infer the returned schema instead of actually run it.
Collaborator
Author
There was a problem hiding this comment.
yes, for DQL, flint.spark.sql(query).show will trigger execution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added pre-validation for duplicate check for output columns in materialized view query. The pre-validation
validateIndex()API was introduced in PR #297.Issues Resolved
#357
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.