Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubygems public key until 20250726 #43

Merged

Conversation

peterzhuamazon
Copy link
Member

@peterzhuamazon peterzhuamazon commented Jul 26, 2024

Description

Update rubygems public key until 20250726

Issues Resolved

Closes opensearch-project/opensearch-build#4893

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Earlopain
Copy link

Openend aws/aws-sdk-ruby#3075 for the test failures

@nhtruong
Copy link
Collaborator

Looks like we'll have to wait for a new release of aws-sdk-ruby. Good thing this gem very rarely needs a release.

@dblock
Copy link
Member

dblock commented Jul 30, 2024

Looks like ./gradlew :distribution:archives:linux-tar:assemble is failing for one of the tests, and it's not a fluke.

@peterzhuamazon
Copy link
Member Author

Seems like 1.9.1 has been released according to:

cc @nhtruong @Earlopain Can we re-run the test or is there additional changes to consume the new sdk version? Thanks!

@peterzhuamazon
Copy link
Member Author

Seems like the failure is related to 2.0: https://github.com/opensearch-project/opensearch-ruby-aws-sigv4/actions/runs/10119006936/job/28118732096?pr=43


Welcome to Gradle 7.3.3!

Here are the highlights of this release:
 - Easily declare new test suites in Java projects
 - Support for Java 17
 - Support for Scala 3

For more details see https://docs.gradle.org/7.3.3/release-notes.html

Starting a Gradle Daemon (subsequent builds will be faster)

FAILURE: Build failed with an exception.

* What went wrong:
Could not determine the dependencies of task ':buildSrc:test'.
> Could not determine the dependencies of null.
   > Could not resolve all task dependencies for configuration ':buildSrc:runtimeClasspath'.
      > Could not find com.netflix.nebula:nebula-core:3.0.0.
        Searched in the following locations:
          - https://repo.maven.apache.org/maven2/com/netflix/nebula/nebula-core/3.0.0/nebula-core-3.0.0.pom
          - https://plugins.gradle.org/m2/com/netflix/nebula/nebula-core/3.0.0/nebula-core-3.0.0.pom
        Required by:
            project :buildSrc > com.netflix.nebula:nebula-publishing-plugin:4.4.4

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.

We probably should not test 2.0 anymore since that branch is not maintained anymore.
Also I dont think this PR changes has anything to do with the failure.

Can we go ahead and merge this PR?
Thanks!

@nhtruong
Copy link
Collaborator

nhtruong commented Aug 6, 2024

@peterzhuamazon let's remove 2.0 from the matrix in this PR as well if you dont mind :)

@peterzhuamazon
Copy link
Member Author

peterzhuamazon commented Aug 6, 2024

@peterzhuamazon let's remove 2.0 from the matrix in this PR as well if you dont mind :)

Send a new PR on this:

Thanks.

@peterzhuamazon
Copy link
Member Author

Rebased this branch.

@nhtruong nhtruong merged commit a7ed5e0 into opensearch-project:main Aug 6, 2024
24 checks passed
@peterzhuamazon peterzhuamazon deleted the key-renewal-until-20250726 branch August 6, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request skip-changelog
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[Renewal] Re-new/Update Rubygems Public Key Until 20250726
4 participants