Fix bug where URL is being signed after being quoted #839
Conversation
fabiopedrosa
requested review from
VachaShah,
dblock,
harshavamsi,
axeoman,
Shephalimittal,
saimedhi and
florianvazelle
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #839 +/- ##
==========================================
- Coverage 71.95% 70.34% -1.61%
==========================================
Files 91 113 +22
Lines 8001 8897 +896
==========================================
+ Hits 5757 6259 +502
- Misses 2244 2638 +394 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
I'm glad we narrowed it down, thanks!
I don't think this is the right fix though. The URL could have been already quoted before, in which case it will start failing again. Look for where it gets quoted in the first place, and preserve the original URL to be used here for signing.
Start by writing a failing test, too, and let's make sure it exists for all transport classes.
|
@dblock I agree, I just won't have time to do that work right now. Is it something AWS can contribute to? |
We can see. Do you have a ticket with customer support by any chance? |
|
it seems this ticket is out of dated. can you please close it ?@fabiopedrosa |
|
Fixed in #848. |
|
@fabiopedrosa If you're relying on the fix you proposed here I suggest reverting to HEAD (and the next release of opensearch-py). This fix doesn't work in half the cases with indices with special characters for example. |
|
@dblock just tried using HEAD and works great. thank you a lot for the fixes, and thank you @nathaliellenaa |
Description
URL is being signed after being quoted, but should be before.
Issues Resolved
Closed #833
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.