-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collapse support added to AsyncSearch helper (#769) #827
Collapse support added to AsyncSearch helper (#769) #827
Conversation
4085e49
to
da1819a
Compare
To maintainers: the same tests seem to fail on other PRs as well :) |
I debugged this but couldn't find a solution. You can rebase with the workaround in #828 for now (or maybe you know how to fix that failure?). |
da1819a
to
26ad804
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #827 +/- ##
==========================================
- Coverage 71.95% 70.39% -1.56%
==========================================
Files 91 113 +22
Lines 8001 8890 +889
==========================================
+ Hits 5757 6258 +501
- Misses 2244 2632 +388 ☔ View full report in Codecov by Sentry. |
26ad804
to
9904043
Compare
Signed-off-by: Radoslaw Kuczynski <[email protected]>
9904043
to
63ee5b2
Compare
Unfortunately, I am not familiar enough with the project to get to the root cause and find the solution without some heavy investigation :) |
Thank you for merging this @dblock :) Any estimates when would this be available in a public release? :) |
We can release quickly. Open an issue that says "Release v. Next". I'd like to merge an update from #814 and make sure things work there too. Currently those tests are failing, someone (you? wink wink) needs to take a look. |
Description
This PR adds collapse support to AsyncSearch helper
Issues Resolved
#769
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.