Skip to content

Conversation

@finnegancarroll
Copy link
Contributor

@finnegancarroll finnegancarroll commented Aug 21, 2025

Description

  • Add CI workflow to publish python wheel to PyPI
    https://pypi.org/project/opensearch-protobufs/
  • Add some additional metadata to the wheel
  • Change name and imports to better match "opensearch protobufs" naming convention.
  • Add python wheel to github release artifacts.

Issues Resolved

opensearch-project/.github#376

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@finnegancarroll finnegancarroll marked this pull request as ready for review August 27, 2025 18:28
May not want to publish on each push to main for python.
gradlew tooling may check if a release already exists,
python GHA does not have this safeguard.

Signed-off-by: Finn Carroll <[email protected]>
@finnegancarroll
Copy link
Contributor Author

@karenyrx can you take a look when you have a chance?

Signed-off-by: Finn Carroll <[email protected]>
peterzhuamazon
peterzhuamazon previously approved these changes Aug 29, 2025
@peterzhuamazon peterzhuamazon dismissed their stale review August 29, 2025 17:54

Mistakenly approved, thanks.

@peterzhuamazon
Copy link
Member

Rename release-drafter to publish-release yml and move all the java content + pypi content there.
Make sure you release pypi first before release draft, which will call jenkins to release java.

Thanks.

@peterzhuamazon peterzhuamazon self-requested a review August 29, 2025 17:55
@finnegancarroll
Copy link
Contributor Author

Hi @karenyrx @peterzhuamazon. I've made the following changes:

  • Move release drafter to publish-release.yml - This workflow will be responsible for all release artifacts (Github release/Maven central/PyPI)
  • Add python wheel to Github release artifacts
  • In contrast to maven central artifacts which are picked up by Jenkins from Github release artifacts, use pypa/gh-action-pypi-publish to publish python artifacts directly.
  • Bump min python version for the wheel to 3.10 (3.8/9 are deprecated).

This should address the previous comment here and keep everything in a single workflow.

Please take a look when convenient and lmk of any additional comments.

@karenyrx karenyrx merged commit 1f3be20 into opensearch-project:main Sep 3, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants